jenkins-bot has submitted this change and it was merged.
Change subject: Documentation: Adding documentation to Translator.php
......................................................................
Documentation: Adding documentation to Translator.php
* Adds comment to line 9 about use of GlobalUser:newFromUser
* Recommended as part of security review
Bug: T86586
Change-Id: Ic7c2962eec7df0147ef3b4eaad7ddff2cc08381c
---
M includes/Translator.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Translator.php b/includes/Translator.php
index 61439f5..499c057 100644
--- a/includes/Translator.php
+++ b/includes/Translator.php
@@ -6,6 +6,7 @@
class Translator {
function __construct( \User $user ) {
+ // GlobalUser::newFromUser must be used so CentralAuth checks
are done
$this->globalUser = GlobalUser::newFromUser( $user );
}
--
To view, visit https://gerrit.wikimedia.org/r/184487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7c2962eec7df0147ef3b4eaad7ddff2cc08381c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Jsahleen <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
