Katie Horn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184499
Change subject: wmf_common functions no longer returning actual nulls
......................................................................
wmf_common functions no longer returning actual nulls
The bug that makes this apparent, is that all chargebacks and
refunds coming through the nightly audit are being tossed on the
grounds that they have a recurring subscription id.
They do not.
Change-Id: Id42978a295cfa2676530cfd2189a85bfff2d8ba1
---
M sites/all/modules/globalcollect_audit/globalcollect_audit.module
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm
refs/changes/99/184499/1
diff --git a/sites/all/modules/globalcollect_audit/globalcollect_audit.module
b/sites/all/modules/globalcollect_audit/globalcollect_audit.module
index e788613..07e87fb 100644
--- a/sites/all/modules/globalcollect_audit/globalcollect_audit.module
+++ b/sites/all/modules/globalcollect_audit/globalcollect_audit.module
@@ -162,8 +162,8 @@
$error = true;
}
- if ( !$error && !is_null(
$parent['contribution_recur_id'] ) ){
- //this is a recurring transaction, and
we're not cool enough to handle that yet. Defer to later.
+ if (!$error &&
!empty($parent['contribution_recur_id'])) {
+ //this is a recurring transaction, and we're not cool enough to
handle that yet. Defer to later.
globalcollect_audit_log_error( "Not
cool enough to handle recurring refunds/chargebacks yet for " . wr1_order_id(
$transactions[$order_id] ) . print_r( $transactions[$order_id], true ),
'RECURRING_CBK' );
$error = true; //well, not really an
"error", per se, but we do want to ignore this for now.
}
--
To view, visit https://gerrit.wikimedia.org/r/184499
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id42978a295cfa2676530cfd2189a85bfff2d8ba1
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Katie Horn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
