jenkins-bot has submitted this change and it was merged.
Change subject: Do not count "ready" in sums sent to statsd
......................................................................
Do not count "ready" in sums sent to statsd
* "ready" does not represent a delta, just all unready jobs, which is huge and
useless
Change-Id: I9133445adc8acb37751097c4728d9824afe3c51b
---
M redisJobRunnerService
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/redisJobRunnerService b/redisJobRunnerService
index 3832e27..f6ef1f6 100755
--- a/redisJobRunnerService
+++ b/redisJobRunnerService
@@ -545,7 +545,7 @@
// to merge after network partitions
that caused aggregator fail-over.
$mapSet[$this->encQueueName( $qType,
$qWiki )] = $now;
}
- $jobs += array_sum( $result );
+ $jobs += ( array_sum( $result ) - $ready );
$this->incrStats( "job-recycle.$qType.$qWiki",
$released );
$this->incrStats( "job-abandon.$qType.$qWiki",
$abandoned );
$this->incrStats( "job-undelay.$qType.$qWiki",
$undelayed );
--
To view, visit https://gerrit.wikimedia.org/r/184412
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9133445adc8acb37751097c4728d9824afe3c51b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/jobrunner
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
