Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/184579

Change subject: Validate language codes in CX API
......................................................................

Validate language codes in CX API

This does not check for allowed languages: that check is done in
the UI and not enforced here. This only disallows putting crap
into these fields.

Bug: T85686
Change-Id: Idf74d6fc45a04b52052081dca1b06921966ac557
---
M api/ApiContentTranslationPublish.php
1 file changed, 8 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/79/184579/1

diff --git a/api/ApiContentTranslationPublish.php 
b/api/ApiContentTranslationPublish.php
index 71204c8..16fe883 100644
--- a/api/ApiContentTranslationPublish.php
+++ b/api/ApiContentTranslationPublish.php
@@ -98,6 +98,14 @@
        public function execute() {
                $params = $this->extractRequestParams();
 
+               if ( !Language::isKnownLanguageTag( $params['from'] ) ) {
+                       $this->dieUsage( 'Invalid source language', 
'invalidsourcelanguage' );
+               }
+
+               if ( !Language::isKnownLanguageTag( $params['to'] ) ) {
+                       $this->dieUsage( 'Invalid target language', 
'invalidtargetlanguage' );
+               }
+
                if ( $params['status'] === 'draft' ) {
                        $this->saveAsDraft();
                } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/184579
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf74d6fc45a04b52052081dca1b06921966ac557
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to