jenkins-bot has submitted this change and it was merged.
Change subject: mw.loader: Remove support for IE6
......................................................................
mw.loader: Remove support for IE6
The client loader doesn't run in IE6.
Since MediaWiki 1.24, the startup module provides IE6 a
javascriptless environment.
Change-Id: I16628e21d6a89a31dc65baf4a22c6fb31dde2535
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 6 insertions(+), 15 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index e0e2963..b63e889 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -732,26 +732,15 @@
*
* @private
* @param {string} text CSS text
- * @param {HTMLElement|jQuery} [nextnode=document.head]
The element where the style tag should be
- * inserted before. Otherwise it will be appended to
`<head>`.
+ * @param {HTMLElement|jQuery} [nextnode=document.head]
The element where the style tag
+ * should be inserted before. Otherwise it will be
appended to `<head>`.
* @return {HTMLElement} Reference to the created
`<style>` element.
*/
function newStyleTag( text, nextnode ) {
var s = document.createElement( 'style' );
// Insert into document before setting cssText
(bug 33305)
if ( nextnode ) {
- // Must be inserted with native
insertBefore, not $.fn.before.
- // When using jQuery to insert it, like
$nextnode.before( s ),
- // then IE6 will throw "Access is
denied" when trying to append
- // to .cssText later. Some kind of
weird security measure.
- //
http://stackoverflow.com/q/12586482/319266
- // Works: jsfiddle.net/zJzMy/1
- // Fails: jsfiddle.net/uJTQz
- // Works again:
http://jsfiddle.net/Azr4w/ (diff: the next 3 lines)
- if ( nextnode.jquery ) {
- nextnode = nextnode.get( 0 );
- }
- nextnode.parentNode.insertBefore( s,
nextnode );
+ $( nextnode ).before( s );
} else {
document.getElementsByTagName( 'head'
)[0].appendChild( s );
}
@@ -1421,7 +1410,9 @@
currReqBase
);
request = sortQuery( request );
- // Append &* to avoid triggering the IE6
extension check
+ // Support: IE6
+ // Append &* to satisfy load.php's
WebRequest::checkUrlExtension test. This script
+ // isn't actually used in IE6, but MediaWiki
enforces it in general.
addScript( sourceLoadScript + '?' + $.param(
request ) + '&*', null, async );
}
--
To view, visit https://gerrit.wikimedia.org/r/184561
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16628e21d6a89a31dc65baf4a22c6fb31dde2535
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: PleaseStand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
