Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184808
Change subject: Toolbar: Update #initialize docs
......................................................................
Toolbar: Update #initialize docs
Docs said that it "must be called immediately after [the toolbar] is
attached to a visible document". Wikia guys wanted to do some pretty
animations or something and were afraid if anything will break. It
won't, let's clarify.
Change-Id: I53cc79008f5f8ca8b9a43e19019902321d273844
---
M src/Toolbar.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/08/184808/1
diff --git a/src/Toolbar.js b/src/Toolbar.js
index 15465b2..1b0ea34 100644
--- a/src/Toolbar.js
+++ b/src/Toolbar.js
@@ -93,7 +93,7 @@
/**
* Sets up handles and preloads required information for the toolbar to work.
- * This must be called immediately after it is attached to a visible document.
+ * This must be called after it is attached to a visible document and before
doing anything else.
*/
OO.ui.Toolbar.prototype.initialize = function () {
this.initialized = true;
--
To view, visit https://gerrit.wikimedia.org/r/184808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53cc79008f5f8ca8b9a43e19019902321d273844
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
