Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184864
Change subject: Disentangle tag lists for filtering vs display
......................................................................
Disentangle tag lists for filtering vs display
Bug: T1316
Change-Id: I1170f32bd612f22e27522a2ce75d5491a4b29d2b
---
M messagebuilder.py
M wikibugs.py
2 files changed, 5 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/wikibugs2
refs/changes/64/184864/1
diff --git a/messagebuilder.py b/messagebuilder.py
index 94b5269..fb987f3 100644
--- a/messagebuilder.py
+++ b/messagebuilder.py
@@ -25,6 +25,8 @@
'resolved': 'Resolved',
}
+ OUTPUT_PROJECT_TYPES = ['briefcase', 'users', 'umbrella']
+
def colorify(self, text, foreground=None, background=None):
outtext = "\x03"
if foreground:
@@ -54,7 +56,8 @@
def build_message(self, useful_info):
text = ''
if useful_info['projects']:
- text += self.colorify(', '.join(useful_info['projects']), 'green')
+ visible_projects = [p for p in self.OUTPUT_PROJECT_TYPES if p in
useful_info['projects']]
+ text += self.colorify(', '.join(visible_projects), 'green')
text += ': '
text += useful_info['title']
text += ' - ' + useful_info['url']
diff --git a/wikibugs.py b/wikibugs.py
index d8430d0..8701247 100644
--- a/wikibugs.py
+++ b/wikibugs.py
@@ -157,14 +157,6 @@
return alltags
- def get_tags_to_display(self, task_page):
- return [
- tag
- for tag, info
- in self.get_tags(task_page).items()
- if info["tagtype"] in ["briefcase", "users", "umbrella"] and not
info["disabled"]
- ]
-
def get_anchors_for_task(self, task_page):
"""
:param url: url to task
@@ -237,7 +229,7 @@
anchor = ""
try:
- projects = self.get_tags_to_display(task_page)
+ projects = [t for t, info in self.get_tags(task_page).items() if
not info['disabled']]
except Exception as e:
if self.raise_errors:
raise
--
To view, visit https://gerrit.wikimedia.org/r/184864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1170f32bd612f22e27522a2ce75d5491a4b29d2b
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/wikibugs2
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
