Cmcmahon has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184897
Change subject: QA: use the shared login step
......................................................................
QA: use the shared login step
The shared code does some extra steps to make sure login succeeds
Change-Id: Ia5145c7576fbb68e72a9df4a780a3dbca5660945
---
M tests/browser/features/modal_on_editable_returnto.feature
M tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted
refs/changes/97/184897/1
diff --git a/tests/browser/features/modal_on_editable_returnto.feature
b/tests/browser/features/modal_on_editable_returnto.feature
index 8e7abe9..99f3430 100644
--- a/tests/browser/features/modal_on_editable_returnto.feature
+++ b/tests/browser/features/modal_on_editable_returnto.feature
@@ -2,7 +2,7 @@
Feature: Modal on editable returnto page
Scenario: User sees modal call to action after registration
- Given I have just registered
+ Given I am logged in
And I have been returned to an editable page
Then I should see a modal call to action
And one action is edit this page
diff --git
a/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
b/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
index c0413bc..987e7f2 100644
---
a/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
+++
b/tests/browser/features/step_definitions/modal_on_editable_returnto_steps.rb
@@ -1,7 +1,3 @@
-Given(/^I have just registered$/) do
- visit(LoginPage).login_with(ENV["MEDIAWIKI_USER"],
ENV["MEDIAWIKI_PASSWORD"])
-end
-
Given(/^I have been returned to an editable page$/) do
visit(EditableReturnToPage)
end
--
To view, visit https://gerrit.wikimedia.org/r/184897
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5145c7576fbb68e72a9df4a780a3dbca5660945
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
