jenkins-bot has submitted this change and it was merged.
Change subject: [BrowserTest] update Cite test for new Journal fields
......................................................................
[BrowserTest] update Cite test for new Journal fields
Maintenance
Change-Id: I36d0c8b438e8fa1847c3947ad52e15d2aadbcfb6
---
M modules/ve-mw/tests/browser/features/cite.feature
M modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
2 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/tests/browser/features/cite.feature
b/modules/ve-mw/tests/browser/features/cite.feature
index 8935f60..400530a 100644
--- a/modules/ve-mw/tests/browser/features/cite.feature
+++ b/modules/ve-mw/tests/browser/features/cite.feature
@@ -67,6 +67,12 @@
When I click Journal
And I fill in the first textarea with "Journal title"
And I fill in the second textarea with "Journal Source date"
+ And I fill in the third textarea with "Journal Last Name"
+ And I fill in the fourth textarea with "Journal First Name"
+ And I fill in the fifth textarea with "Journal Source Date"
+ And I fill in the sixth textarea with "Journal Journal"
+ And I fill in the seventh textarea with "Journal Access Date"
+ And I fill in the eighth textarea with "Journal DOI"
And the Journal input field titles are in the correct order
And I click Insert Citation
And I click Save page
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
index 2b4ac7e..7b29d37 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
@@ -96,7 +96,7 @@
page.wait_until(10) do
page.diff_view.include? 'Cite VisualEditor Test'
end
- expect(page.diff_view).to match '<ref>{{Cite journal|title = Journal
title|date = Journal Source date}}</ref>Cite VisualEditor Test'
+ expect(page.diff_view).to match '<ref>{{Cite journal|url = Journal
title|title = Journal Source date|last = Journal Last Name|first = Journal
First Name|date = Journal Source Date|journal = Journal Journal|accessdate =
Journal Access Date|doi = Journal DOI}}</ref>Cite VisualEditor Test'
end
end
--
To view, visit https://gerrit.wikimedia.org/r/184785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36d0c8b438e8fa1847c3947ad52e15d2aadbcfb6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Ryasmeen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
