jenkins-bot has submitted this change and it was merged.
Change subject: [BrowserTest] Add test for missing parameter error msg
......................................................................
[BrowserTest] Add test for missing parameter error msg
Test checks for 'Required parameter missing' message, 'Go back'
and 'Continue anyway'.
Paired with Rummana writing this
Change-Id: I9c3aab7f7af9ccde8f0dadd2839a7a698f7341ee
---
M modules/ve-mw/tests/browser/features/cite.feature
M modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
3 files changed, 24 insertions(+), 1 deletion(-)
Approvals:
Cmcmahon: Looks good to me, approved
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/tests/browser/features/cite.feature
b/modules/ve-mw/tests/browser/features/cite.feature
index 8935f60..a9b7b6e 100644
--- a/modules/ve-mw/tests/browser/features/cite.feature
+++ b/modules/ve-mw/tests/browser/features/cite.feature
@@ -77,4 +77,12 @@
When I click Basic
Then I should see the VisualEditor interface
And I should see the Options use this group text
- And I should see the General references
\ No newline at end of file
+ And I should see the General references
+
+ Scenario: Error message for required field not present
+ When I click Journal
+ And I fill in the first textarea with "Journal title"
+ And I click Insert Citation
+ Then I should see a Required parameters missing error
+ And I should see a Go back button
+ And I should see a Continue anyway button
\ No newline at end of file
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
index 2b4ac7e..0663646 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
@@ -118,6 +118,18 @@
end
end
+Then(/^I should see a Continue anyway button$/) do
+
expect(on(VisualEditorPage).required_parameters_continue_anyway_element.when_present).to
be_visible
+end
+
+Then(/^I should see a Go back button$/) do
+
expect(on(VisualEditorPage).required_parameters_go_back_element.when_present).to
be_visible
+end
+
+Then(/^I should see a Required parameters missing error$/) do
+
expect(on(VisualEditorPage).required_parameters_missing_message_element.when_present).to
be_visible
+end
+
Then(/^I should see the General references$/) do
expect(on(VisualEditorPage).cite_group_name_textarea_element).to be_visible
end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 63e956e..967376a 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -171,6 +171,9 @@
div(:extension_reference, class: 've-ui-mwReferenceResultWidget-shield',
frame: frame)
span(:existing_reference, text: 'Use an existing reference', frame: frame)
a(:remove_template, title: 'Remove template', frame: frame)
+ span(:required_parameters_continue_anyway, text: 'Continue anyway', frame:
frame)
+ span(:required_parameters_go_back, text: 'Go back', frame: frame)
+ span(:required_parameters_missing_message, text: 'Required parameters
missing', frame: frame)
div(:suggestion_list, class: 've-ui-mwTitleInputWidget-menu')
span(:another_save_page, class: 'oo-ui-labelElement-label', text: 'Save
page', frame: frame)
div(:content_box, class: 've-ce-documentNode ve-ce-branchNode', frame:
frame) # ALSO USED IN LANGUAGE SCREENSHOT
--
To view, visit https://gerrit.wikimedia.org/r/184788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c3aab7f7af9ccde8f0dadd2839a7a698f7341ee
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Ryasmeen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
