Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/184919
Change subject: Fix change handling for connected pages
......................................................................
Fix change handling for connected pages
if a change is not a site link usage but the page
is connected via a site link, then we still
need to consider it for usage.
we need to do a site link lookup and check if the
page is connected.
(part 2 of bug fix)
Bug: T86765
Change-Id: I445d77bb37cee7ffbd629e4b6ed45da634c3eb6f
(cherry picked from commit ffbb3137ef2b7fb0b1a31f6c283b3316407f4cf3)
---
M client/includes/Usage/SiteLinkUsageLookup.php
M client/tests/phpunit/includes/Usage/SiteLinkUsageLookupTest.php
2 files changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/19/184919/1
diff --git a/client/includes/Usage/SiteLinkUsageLookup.php
b/client/includes/Usage/SiteLinkUsageLookup.php
index b1c11b4..7712007 100644
--- a/client/includes/Usage/SiteLinkUsageLookup.php
+++ b/client/includes/Usage/SiteLinkUsageLookup.php
@@ -89,10 +89,6 @@
return new ArrayIterator( array() );
}
- if ( $aspects && !in_array( EntityUsage::SITELINK_USAGE,
$aspects ) ) {
- return new ArrayIterator( array() );
- }
-
$numericItemIds = $this->getNumericItemIds( $entityIds );
$rows = $this->siteLinkLookup->getLinks( $numericItemIds,
array( $this->clientSiteId ) );
diff --git a/client/tests/phpunit/includes/Usage/SiteLinkUsageLookupTest.php
b/client/tests/phpunit/includes/Usage/SiteLinkUsageLookupTest.php
index de7c964..206c078 100644
--- a/client/tests/phpunit/includes/Usage/SiteLinkUsageLookupTest.php
+++ b/client/tests/phpunit/includes/Usage/SiteLinkUsageLookupTest.php
@@ -104,6 +104,13 @@
$actual = iterator_to_array( $actual );
$this->assertEmpty( $actual );
+ $actual = $lookup->getPagesUsing( array( $q23 ), array(
EntityUsage::OTHER_USAGE ) );
+ $this->assertInstanceOf( 'Iterator', $actual );
+
+ $actual = iterator_to_array( $actual );
+ $usages = $actual[0]->getUsages();
+ $usage = reset( $usages );
+ $this->assertEquals( $q23, $usage->getEntityId() );
$actual = $lookup->getPagesUsing( array( $q42, $q23, $p11 ) );
$this->assertInstanceOf( 'Iterator', $actual );
--
To view, visit https://gerrit.wikimedia.org/r/184919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I445d77bb37cee7ffbd629e4b6ed45da634c3eb6f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf14
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
