Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/185066
Change subject: dialog: Provide a 'larger' size for things for which 'large'
isn't enough
......................................................................
dialog: Provide a 'larger' size for things for which 'large' isn't enough
Bug: T86396
Change-Id: Ib70e20b1086bcba91984bc5ba64830621c10a398
---
M demos/pages/dialogs.js
M src/Window.js
M src/WindowManager.js
3 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/66/185066/1
diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js
index 0a4794f..95f1729 100644
--- a/demos/pages/dialogs.js
+++ b/demos/pages/dialogs.js
@@ -189,6 +189,7 @@
new SamplePage( 'small', { $: this.$, label: 'Small',
icon: 'window' } ),
new SamplePage( 'medium', { $: this.$, label: 'Medium',
icon: 'window' } ),
new SamplePage( 'large', { $: this.$, label: 'Large',
icon: 'window' } ),
+ new SamplePage( 'larger', { $: this.$, label: 'Larger',
icon: 'window' } ),
new SamplePage( 'full', { $: this.$, label: 'Full',
icon: 'window' } )
];
this.bookletLayout.addPages( this.pages );
@@ -236,6 +237,12 @@
}
},
{
+ name: 'Simple dialog (larger)',
+ config: {
+ size: 'larger'
+ }
+ },
+ {
name: 'Simple dialog (full)',
config: {
size: 'full'
diff --git a/src/Window.js b/src/Window.js
index 8c4e4e9..490d8b7 100644
--- a/src/Window.js
+++ b/src/Window.js
@@ -35,8 +35,8 @@
*
* @constructor
* @param {Object} [config] Configuration options
- * @cfg {string} [size] Symbolic name of dialog size, `small`, `medium`,
`large` or `full`; omit to
- * use #static-size
+ * @cfg {string} [size] Symbolic name of dialog size, `small`, `medium`,
`large`, `larger` or
+ * `full`; omit to use #static-size
*/
OO.ui.Window = function OoUiWindow( config ) {
// Configuration initialization
@@ -296,7 +296,7 @@
/**
* Get the window size.
*
- * @return {string} Symbolic size name, e.g. 'small', 'medium', 'large', 'full'
+ * @return {string} Symbolic size name, e.g. `small`, `medium`, `large`,
`larger`, `full`
*/
OO.ui.Window.prototype.getSize = function () {
return this.size;
diff --git a/src/WindowManager.js b/src/WindowManager.js
index 1f65e3a..83fda68 100644
--- a/src/WindowManager.js
+++ b/src/WindowManager.js
@@ -138,6 +138,9 @@
large: {
width: 700
},
+ larger: {
+ width: 900
+ },
full: {
// These can be non-numeric because they are never used in
calculations
width: '100%',
--
To view, visit https://gerrit.wikimedia.org/r/185066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib70e20b1086bcba91984bc5ba64830621c10a398
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
