NoahM has uploaded a new change for review.
https://gerrit.wikimedia.org/r/185101
Change subject: Prevent patrol footer from appearing on translation pages
......................................................................
Prevent patrol footer from appearing on translation pages
Hooks getUserPermissionsErrors to return false when action is 'patrol'.
Bug: T44162
Change-Id: Ia1ccd346acf92a129b7d094b3085ea45ff321bbf
---
M TranslateHooks.php
M i18n/pagetranslation/en.json
M tag/PageTranslationHooks.php
3 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/01/185101/1
diff --git a/TranslateHooks.php b/TranslateHooks.php
index 42d5abe..a49d1a4 100644
--- a/TranslateHooks.php
+++ b/TranslateHooks.php
@@ -141,6 +141,9 @@
// Prevent editing of translation pages directly
$wgHooks['getUserPermissionsErrorsExpensive'][] =
'PageTranslationHooks::preventDirectEditing';
+ // Prevent patroling of translation pages
+ $wgHooks['getUserPermissionsErrors'][] =
+ 'PageTranslationHooks::preventPatrolling';
// Our custom header for translation pages
$wgHooks['ArticleViewHeader'][] =
'PageTranslationHooks::translatablePageHeader';
diff --git a/i18n/pagetranslation/en.json b/i18n/pagetranslation/en.json
index 3dd9793..0562e47 100644
--- a/i18n/pagetranslation/en.json
+++ b/i18n/pagetranslation/en.json
@@ -67,6 +67,7 @@
"tpt-languages-nonzero": "$1 ($2% translated)",
"tpt-tab-translate": "Translate",
"tpt-target-page": "This page cannot be updated manually.\nThis page is
a translation of the page [[$1]] and the translation can be updated using [$2
the translation tool].",
+ "tpt-patrolling-blocked": "This page cannot be patrolled. Instead, use
the translate action to review it.",
"tpt-unknown-page": "This namespace is reserved for content page
translations.\nThe page you are trying to edit does not seem to correspond any
page marked for translation.",
"tpt-translation-restricted": "Translation of this page to this
language has been prevented by a translation administrator.\n\nReason: $1",
"tpt-discouraged-language-force-header": "This page cannot be
translated to $1.",
diff --git a/tag/PageTranslationHooks.php b/tag/PageTranslationHooks.php
index 7c01e7e..5136a0b 100644
--- a/tag/PageTranslationHooks.php
+++ b/tag/PageTranslationHooks.php
@@ -595,6 +595,21 @@
}
/**
+ * Prevent patrol links from appearing on translation pages.
+ * Hook: getUserPermissionsErrors
+ */
+ public static function preventPatrolling( Title $title, User $user,
$action, &$result ) {
+ $page = TranslatablePage::isTranslationPage( $title );
+
+ if ( $page !== false && $action === 'patrol' ) {
+ $result[] = 'tpt-patrolling-blocked';
+ return false;
+ }
+
+ return true;
+ }
+
+ /**
* Redirects the delete action to our own for translatable pages.
* Hook: ArticleConfirmDelete
*
--
To view, visit https://gerrit.wikimedia.org/r/185101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1ccd346acf92a129b7d094b3085ea45ff321bbf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: NoahM <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
