jenkins-bot has submitted this change and it was merged.

Change subject: Load legacy JS modules for the skin to unbreak Common.js
......................................................................


Load legacy JS modules for the skin to unbreak Common.js

If the skin loads mediawiki.legacy.wikibits, load that module from
Special:CX too so that Common.js does not fail.

For example, in eswiki, Special:CX has js error because of this.

Bug: T86850
Change-Id: Ide835bf96d215e64bb4e6e095818e23e31c9a5a9
---
M specials/SpecialContentTranslation.php
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Amire80: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/specials/SpecialContentTranslation.php 
b/specials/SpecialContentTranslation.php
index 5afe6c7..4214e4e 100644
--- a/specials/SpecialContentTranslation.php
+++ b/specials/SpecialContentTranslation.php
@@ -65,6 +65,11 @@
                        'mediawiki.page.ready',
                ) );
 
+               // Load legacy modules if any, for the skin.
+               // Some wikis have Common.js scripts that depend on this module.
+               $defaultSkinModules = $skin->getDefaultModules();
+               $out->addModules( $defaultSkinModules['legacy'] );
+
                wfRunHooks( 'BeforePageDisplay', array( &$out, &$skin ) );
 
                $out->addHTML( $out->headElement( $skin ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/185121
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ide835bf96d215e64bb4e6e095818e23e31c9a5a9
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to