[MediaWiki-commits] [Gerrit] Make rollover state a link to topic history - change (mediawiki...Flow)

jenkins-bot (Code Review) Thu, 15 Jan 2015 10:22:35 -0800

jenkins-bot has submitted this change and it was merged.

Change subject: Make rollover state a link to topic history
......................................................................



Make rollover state a link to topic history

We add a link to history behind post timestamps - this also adds one for the
link in the topic titlebar.

Bug: T77900
Change-Id: Iff8d51ecdae70e531baa46cd124c9176bc4bd102
---
M handlebars/compiled/flow_block_topic.handlebars.php
M handlebars/compiled/flow_block_topiclist.handlebars.php
M handlebars/flow_topic_titlebar_content.handlebars
3 files changed, 22 insertions(+), 16 deletions(-)

Approvals:
  EBernhardson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/handlebars/compiled/flow_block_topic.handlebars.php 
b/handlebars/compiled/flow_block_topic.handlebars.php
index 0528f77..ff51f59 100644
--- a/handlebars/compiled/flow_block_topic.handlebars.php
+++ b/handlebars/compiled/flow_block_topic.handlebars.php
@@ -76,11 +76,13 @@
 
        '.LCRun3::ch($cx, 'l10n', 
Array(Array('flow-topic-comments',((isset($in['reply_count']) && is_array($in)) 
? $in['reply_count'] : null)),Array()), 'encq').' &bull;
 
-       '.((LCRun3::ifvar($cx, ((isset($in['last_updated']) && is_array($in)) ? 
$in['last_updated'] : null))) ? '
-               '.LCRun3::ch($cx, 'timestamp', 
Array(Array(((isset($in['last_updated']) && is_array($in)) ? 
$in['last_updated'] : null)),Array()), 'encq').'
-       ' : '
-               '.LCRun3::ch($cx, 'uuidTimestamp', 
Array(Array(((isset($in['postId']) && is_array($in)) ? $in['postId'] : 
null)),Array()), 'encq').'
-       ').'
+       <a 
href="'.htmlentities((string)((isset($in['links']['topic-history']['url']) && 
is_array($in['links']['topic-history'])) ? $in['links']['topic-history']['url'] 
: null), ENT_QUOTES, 'UTF-8').'" class="flow-timestamp-anchor">
+               '.((LCRun3::ifvar($cx, ((isset($in['last_updated']) && 
is_array($in)) ? $in['last_updated'] : null))) ? '
+                       '.LCRun3::ch($cx, 'timestamp', 
Array(Array(((isset($in['last_updated']) && is_array($in)) ? 
$in['last_updated'] : null)),Array()), 'encq').'
+               ' : '
+                       '.LCRun3::ch($cx, 'uuidTimestamp', 
Array(Array(((isset($in['postId']) && is_array($in)) ? $in['postId'] : 
null)),Array()), 'encq').'
+               ').'
+       </a>
 </div>
 '.((LCRun3::ifvar($cx, ((isset($in['isModerated']) && is_array($in)) ? 
$in['isModerated'] : null))) ? '
        <div class="flow-moderated-topic-title 
flow-ui-text-truncated">'.htmlentities((string)((isset($in['noop']) && 
is_array($in)) ? $in['noop'] : null), ENT_QUOTES, 'UTF-8').''.LCRun3::p($cx, 
'flow_topic_moderation_flag', Array(Array($in),Array())).'
@@ -326,4 +328,4 @@
 </div>
 ';
 }
-?>
\ No newline at end of file
+?>
diff --git a/handlebars/compiled/flow_block_topiclist.handlebars.php 
b/handlebars/compiled/flow_block_topiclist.handlebars.php
index 4e6a365..eed7b30 100644
--- a/handlebars/compiled/flow_block_topiclist.handlebars.php
+++ b/handlebars/compiled/flow_block_topiclist.handlebars.php
@@ -213,11 +213,13 @@
 
        '.LCRun3::ch($cx, 'l10n', 
Array(Array('flow-topic-comments',((isset($in['reply_count']) && is_array($in)) 
? $in['reply_count'] : null)),Array()), 'encq').' &bull;
 
-       '.((LCRun3::ifvar($cx, ((isset($in['last_updated']) && is_array($in)) ? 
$in['last_updated'] : null))) ? '
-               '.LCRun3::ch($cx, 'timestamp', 
Array(Array(((isset($in['last_updated']) && is_array($in)) ? 
$in['last_updated'] : null)),Array()), 'encq').'
-       ' : '
-               '.LCRun3::ch($cx, 'uuidTimestamp', 
Array(Array(((isset($in['postId']) && is_array($in)) ? $in['postId'] : 
null)),Array()), 'encq').'
-       ').'
+       <a 
href="'.htmlentities((string)((isset($in['links']['topic-history']['url']) && 
is_array($in['links']['topic-history'])) ? $in['links']['topic-history']['url'] 
: null), ENT_QUOTES, 'UTF-8').'" class="flow-timestamp-anchor">
+               '.((LCRun3::ifvar($cx, ((isset($in['last_updated']) && 
is_array($in)) ? $in['last_updated'] : null))) ? '
+                       '.LCRun3::ch($cx, 'timestamp', 
Array(Array(((isset($in['last_updated']) && is_array($in)) ? 
$in['last_updated'] : null)),Array()), 'encq').'
+               ' : '
+                       '.LCRun3::ch($cx, 'uuidTimestamp', 
Array(Array(((isset($in['postId']) && is_array($in)) ? $in['postId'] : 
null)),Array()), 'encq').'
+               ').'
+       </a>
 </div>
 '.((LCRun3::ifvar($cx, ((isset($in['isModerated']) && is_array($in)) ? 
$in['isModerated'] : null))) ? '
        <div class="flow-moderated-topic-title 
flow-ui-text-truncated">'.htmlentities((string)((isset($in['noop']) && 
is_array($in)) ? $in['noop'] : null), ENT_QUOTES, 'UTF-8').''.LCRun3::p($cx, 
'flow_topic_moderation_flag', Array(Array($in),Array())).'
diff --git a/handlebars/flow_topic_titlebar_content.handlebars 
b/handlebars/flow_topic_titlebar_content.handlebars
index 8c8dec7..1ed68f6 100644
--- a/handlebars/flow_topic_titlebar_content.handlebars
+++ b/handlebars/flow_topic_titlebar_content.handlebars
@@ -38,11 +38,13 @@
 
        {{l10n "flow-topic-comments" reply_count}} &bull;
 
-       {{#if last_updated}}
-               {{timestamp last_updated}}
-       {{else}}
-               {{uuidTimestamp postId}}
-       {{/if}}
+       <a href="{{links.topic-history.url}}" class="flow-timestamp-anchor">
+               {{#if last_updated}}
+                       {{timestamp last_updated}}
+               {{else}}
+                       {{uuidTimestamp postId}}
+               {{/if}}
+       </a>
 </div>
 {{#if isModerated}}
        <div class="flow-moderated-topic-title flow-ui-text-truncated">

-- 
To view, visit https://gerrit.wikimedia.org/r/180754
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff8d51ecdae70e531baa46cd124c9176bc4bd102
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Make rollover state a link to topic history - change (mediawiki...Flow)

Reply via email to