jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Don't return a value from Schema.log"
......................................................................
Revert "Don't return a value from Schema.log"
This reverts commit 6121c5d4fb322fb88cccc4c640316bbac666babb.
Need to do this more carefully.
Caused: T86941
Bug: T86941
Change-Id: I3187dade35a2c4c7d622b24a16c2ff41a4acf1c9
---
M javascripts/Schema.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
Bmansurov: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/javascripts/Schema.js b/javascripts/Schema.js
index d2ebf50..046e762 100644
--- a/javascripts/Schema.js
+++ b/javascripts/Schema.js
@@ -42,10 +42,13 @@
*
* @method
* @param {Object} data to log
+ * @return {jQuery.Deferred}
*/
log: function ( data ) {
if ( mw.eventLog ) {
- mw.eventLog.logEvent( this.name, $.extend(
this.defaults, data ) );
+ return mw.eventLog.logEvent( this.name,
$.extend( this.defaults, data ) );
+ } else {
+ return $.Deferred().reject( 'EventLogging not
installed.' );
}
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/185211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3187dade35a2c4c7d622b24a16c2ff41a4acf1c9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
