jenkins-bot has submitted this change and it was merged.
Change subject: Do not trigger "change" event when handling empty elements
......................................................................
Do not trigger "change" event when handling empty elements
Retains "disabled" state on "remove" toolbars.
Bug: T76849
Change-Id: I7210719ddc87af3199a1a5412db7a283f97d0b12
---
M lib/resources/jquery.wikibase/jquery.wikibase.sitelinklistview.js
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinklistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinklistview.js
index bba89d1..47b4f0c 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.sitelinklistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.sitelinklistview.js
@@ -173,9 +173,12 @@
.on(
'listviewitemremoved.' + this.widgetName
+ ' listviewitemadded.' + this.widgetName,
- function( event ) {
+ function( event, sitelinkview ) {
self._refreshCounter();
- self._trigger( 'change' );
+ if( sitelinkview ) {
+ // Do not trigger "change" event when
handling empty elements.
+ self._trigger( 'change' );
+ }
}
);
},
--
To view, visit https://gerrit.wikimedia.org/r/183456
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7210719ddc87af3199a1a5412db7a283f97d0b12
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
