jenkins-bot has submitted this change and it was merged.

Change subject: Add svg image of bullet
......................................................................


Add svg image of bullet

* Adds svg version of bullet.
* It has a hack in css so that png will be targeted at ie 8 or lower.
* There was no way around it since list-style-image carnt be used twice. The 
hack adds \9 to end of png file.

Edokter suggested to use \9

Note this has been tested

Bug: T37338
Change-Id: I795c31a68c383b8fc4557ee00312a5b1aecd09a3
---
M components/common.less
A images/bullet-icon.svg
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Edokter: Looks good to me, but someone else must approve
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/components/common.less b/components/common.less
index c25a26a..f85fbb0 100644
--- a/components/common.less
+++ b/components/common.less
@@ -126,7 +126,9 @@
 
 ul {
        list-style-type: disc;
-       .list-style-image('images/bullet-icon.png');
+       list-style-image: url(images/bullet-icon.svg);
+       /* Fallback to PNG bullet for IE 8 and below using CSS hack */
+       list-style-image: url(images/bullet-icon.png)\9;
 }
 
 pre, .mw-code {
diff --git a/images/bullet-icon.svg b/images/bullet-icon.svg
new file mode 100644
index 0000000..fa83a67
--- /dev/null
+++ b/images/bullet-icon.svg
@@ -0,0 +1,3 @@
+<svg xmlns:svg="http://www.w3.org/2000/svg"; xmlns="http://www.w3.org/2000/svg"; 
version="1.1" width="5" height="13">
+<path d="m4.820297 5.8103962a2.1173267 2.1173267 0 1 1-4.23465347 0 2.1173267 
2.1173267 0 1 1 4.23465347 0z" 
transform="matrix(1.1807342,0,0,1.1807342,-0.69148932,2.0972643)" 
fill="#00528c"/>
+</svg>
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/182827
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I795c31a68c383b8fc4557ee00312a5b1aecd09a3
Gerrit-PatchSet: 17
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: MarkAHershberger <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to