jenkins-bot has submitted this change and it was merged.
Change subject: Move deprecated HTML attributes to CSS
......................................................................
Move deprecated HTML attributes to CSS
Add missing autoloader entries while at it.
Bug: T74519
Change-Id: I71d6c8487c176a033a00a0213f60e7e7e2ab19d6
---
M LiquidThreads.php
M lqt.css
M pages/TalkpageView.php
3 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
He7d3r: Looks good to me, but someone else must approve
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/LiquidThreads.php b/LiquidThreads.php
index 076472a..9d9f7b4 100644
--- a/LiquidThreads.php
+++ b/LiquidThreads.php
@@ -229,6 +229,8 @@
// Pagers
$wgAutoloadClasses['LqtDiscussionPager'] = $dir . '/pages/TalkpageView.php';
+$wgAutoloadClasses['LqtNewMessagesPager'] = $dir .
'/pages/NewUserMessagesView.php';
+$wgAutoloadClasses['TalkpageHistoryPager'] = $dir .
'/pages/TalkpageHistoryView.php';
// Special pages
$wgAutoloadClasses['ThreadActionPage'] = $dir . '/pages/ThreadActionPage.php';
diff --git a/lqt.css b/lqt.css
index 248404b..9e4d765 100644
--- a/lqt.css
+++ b/lqt.css
@@ -482,6 +482,11 @@
margin: 30px auto 10px;
}
+.TalkpagePager_nav td{
+ vertical-align: top;
+ text-align: center;
+}
+
.lqt-drag-confirm label {
margin-right: 20px;
}
diff --git a/pages/TalkpageView.php b/pages/TalkpageView.php
index a0fe8ef..8c2fd70 100644
--- a/pages/TalkpageView.php
+++ b/pages/TalkpageView.php
@@ -568,9 +568,9 @@
$navClass = htmlspecialchars( $this->getNavClass() );
$s = "<table class=\"$navClass\" align=\"center\"
cellpadding=\"3\"><tr>\n";
- $cellAttrs = 'valign="top" align="center" width="' . 100 /
count( $links ) . '%"';
+ $cellAttrs = 'width: ' . 100 / count( $links ) . '%';
foreach ( $labels as $type => $label ) {
- $s .= "<td $cellAttrs>{$links[$type]}</td>\n";
+ $s .= "<td style='$cellAttrs'>{$links[$type]}</td>\n";
}
$s .= "</tr></table>\n";
return $s;
--
To view, visit https://gerrit.wikimedia.org/r/182140
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71d6c8487c176a033a00a0213f60e7e7e2ab19d6
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Phoenix303 <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: He7d3r <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
