Umherirrender has uploaded a new change for review. Change subject: Add Database::unsetDuplicateFields ......................................................................
Add Database::unsetDuplicateFields There is no need to select a field twice inside one query. This patch removed duplicate fields. It also warns on fields, used as alias and normal fields, because that is not a sql error (for example: SELECT page_id AS page_namespace, page_namespace FROM page) Change-Id: I4107d4754dc9e6fed10d528fe9726142c00e46d5 --- M includes/db/Database.php M tests/phpunit/includes/db/DatabaseSQLTest.php 2 files changed, 65 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/64/32264/1 -- To view, visit https://gerrit.wikimedia.org/r/32264 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4107d4754dc9e6fed10d528fe9726142c00e46d5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
