Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/185659
Change subject: Replace zwnj in the footer with a nicer CSS solution
......................................................................
Replace zwnj in the footer with a nicer CSS solution
Bug: T86281
Change-Id: I3e1bee447a550f68b66ef1ebf9b91199b3636aff
---
M includes/skins/SkinMinerva.php
M less/footer.less
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/59/185659/1
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 2969000..5e46d41 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -1074,11 +1074,10 @@
$desktop = wfMessage( 'mobile-frontend-view-desktop'
)->escaped();
$mobile = wfMessage( 'mobile-frontend-view-mobile' )->escaped();
- // ‌ is needed for correct ligatures in some scripts (e.g.
Arabic)
$switcherHtml = <<<HTML
<h2>{$this->getSitename()}</h2>
<ul>
- <li>{$mobile}‌</li><li><a id="mw-mf-display-toggle"
href="{$url}">{$desktop}</a></li>
+ <li>{$mobile}</li><li><a id="mw-mf-display-toggle"
href="{$url}">{$desktop}</a></li>
</ul>
HTML;
diff --git a/less/footer.less b/less/footer.less
index 7784004..5143eac 100644
--- a/less/footer.less
+++ b/less/footer.less
@@ -41,6 +41,15 @@
padding: 0 8px;
border-right: 1px solid @colorGray10;
+ // A hack to avoid connecting letters in cursive
scripts such as Arabic.
+ // A better solution would be to apply something like
unicode-bidi: embed,
+ // but apparently Firefox doesn't actually render it
correcty.
+ // See https://phabricator.wikimedia.org/T86281
+ &:after {
+ content: ' ';
+ font-size: 0;
+ }
+
&:last-child {
border: none;
}
--
To view, visit https://gerrit.wikimedia.org/r/185659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e1bee447a550f68b66ef1ebf9b91199b3636aff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
