jenkins-bot has submitted this change and it was merged.
Change subject: Remove workaround for missing dependency to Extension:Math
......................................................................
Remove workaround for missing dependency to Extension:Math
Follow up to I96310d24fe66f677c2b97345af994bd1b210fa31
The workaround that creates a dummy class in case the
Math extension has not been loaded by Jenkins is no longer required.
Bug: T86312
Change-Id: Ifd8a9b97d5c8982f99f3cd29d0b8cf161c0ead14
---
M tests/MathObjectTest.php
1 file changed, 0 insertions(+), 14 deletions(-)
Approvals:
Physikerwelt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/MathObjectTest.php b/tests/MathObjectTest.php
index 46e5ece..1b8cda3 100644
--- a/tests/MathObjectTest.php
+++ b/tests/MathObjectTest.php
@@ -1,15 +1,4 @@
<?php
-//TODO: fix that ugly workaround
-/*
- * If the unit tests are run by jenkins, the Math extension is not present.
- * Thus a fake MathMathML class must be created in order to derive the
- * MathObject class that extends MathMathML
- */
-function createDummyMathMLClass(){
- class MathMathML{}
- return true;
-}
-
/**
* Test the mathObject script.
*
@@ -37,9 +26,6 @@
public function test() {
- if ( ! class_exists("MathMathML") ){
- createDummyMathMLClass();
- }
$comment = MathObject::extractMathTagsFromWikiText(
$this->HTMLComment );
$this->assertEquals( 0, sizeof( $comment ) );
$noWiki = MathObject::extractMathTagsFromWikiText(
$this->noWiki );
--
To view, visit https://gerrit.wikimedia.org/r/185675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd8a9b97d5c8982f99f3cd29d0b8cf161c0ead14
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MathSearch
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <[email protected]>
Gerrit-Reviewer: Physikerwelt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
