Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/185843
Change subject: Drop unused use clauses from Lib
......................................................................
Drop unused use clauses from Lib
I found these with a regex.
Change-Id: I30e44dc2626b708e93c4610204887d3d5becaa50
---
M lib/tests/phpunit/MockRepository.php
M lib/tests/phpunit/Validators/AlternativeValidatorTest.php
M lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterFactoryTest.php
M lib/tests/phpunit/formatters/FormatterLabelLookupFactoryTest.php
M lib/tests/phpunit/store/BufferingTermLookupTest.php
5 files changed, 6 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/43/185843/1
diff --git a/lib/tests/phpunit/MockRepository.php
b/lib/tests/phpunit/MockRepository.php
index ffd0a29..5330eb9 100644
--- a/lib/tests/phpunit/MockRepository.php
+++ b/lib/tests/phpunit/MockRepository.php
@@ -95,7 +95,7 @@
/**
* @see EntityLookup::getEntity
*
- * @param EntityID $entityId
+ * @param EntityId $entityId
*
* @return EntityDocument|null
*
@@ -111,7 +111,7 @@
* @since 0.4
* @see EntityRevisionLookup::getEntityRevision
*
- * @param EntityID $entityId
+ * @param EntityId $entityId
* @param int|string $revisionId The desired revision id, or
LATEST_FROM_SLAVE or LATEST_FROM_MASTER.
*
* @throws StorageException
@@ -160,7 +160,7 @@
*
* @since 0.4
*
- * @param EntityID $entityId
+ * @param EntityId $entityId
*
* @return bool
*/
@@ -478,7 +478,7 @@
*
* @since 0.4
*
- * @param EntityID[] $entityIds
+ * @param EntityId[] $entityIds
*
* @return Entity|null[]
*/
@@ -578,7 +578,7 @@
/**
* @see EntityRevisionLookup::getLatestRevisionId
*
- * @param EntityID $entityId
+ * @param EntityId $entityId
* @param string $mode
*
* @return int|false
diff --git a/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
b/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
index 1185e3d..76721ec 100644
--- a/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
+++ b/lib/tests/phpunit/Validators/AlternativeValidatorTest.php
@@ -2,7 +2,6 @@
namespace Wikibase\Test\Validators;
-use DataValues\StringValue;
use Wikibase\Validators\AlternativeValidator;
use Wikibase\Validators\RegexValidator;
use Wikibase\Validators\ValidatorErrorLocalizer;
diff --git
a/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterFactoryTest.php
b/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterFactoryTest.php
index 3fc53d7..b5a716a 100644
--- a/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterFactoryTest.php
+++ b/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterFactoryTest.php
@@ -3,7 +3,6 @@
namespace Wikibase\Lib\Test;
use ValueFormatters\FormatterOptions;
-use ValueFormatters\StringFormatter;
use Wikibase\Lib\EntityIdHtmlLinkFormatterFactory;
use Wikibase\Lib\SnakFormatter;
diff --git a/lib/tests/phpunit/formatters/FormatterLabelLookupFactoryTest.php
b/lib/tests/phpunit/formatters/FormatterLabelLookupFactoryTest.php
index 02d334a..be47d85 100644
--- a/lib/tests/phpunit/formatters/FormatterLabelLookupFactoryTest.php
+++ b/lib/tests/phpunit/formatters/FormatterLabelLookupFactoryTest.php
@@ -5,7 +5,6 @@
use Language;
use OutOfBoundsException;
use ValueFormatters\FormatterOptions;
-use ValueFormatters\StringFormatter;
use ValueFormatters\ValueFormatter;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\LanguageFallbackChain;
diff --git a/lib/tests/phpunit/store/BufferingTermLookupTest.php
b/lib/tests/phpunit/store/BufferingTermLookupTest.php
index 6658970..abbec6d 100644
--- a/lib/tests/phpunit/store/BufferingTermLookupTest.php
+++ b/lib/tests/phpunit/store/BufferingTermLookupTest.php
@@ -59,7 +59,7 @@
$termIndex->expects( $this->exactly( $getTermsOfEntityCalls ) )
->method( 'getTermsOfEntity' )
- ->will( $this->returnCallback( function( EntityID $id,
$termTypes, $languages = null ) use ( $terms ) {
+ ->will( $this->returnCallback( function( EntityId $id,
$termTypes, $languages = null ) use ( $terms ) {
if ( $languages !== null ) {
$terms = array_intersect_key( $terms,
array_flip( $languages ) );
}
--
To view, visit https://gerrit.wikimedia.org/r/185843
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30e44dc2626b708e93c4610204887d3d5becaa50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits