Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/185845
Change subject: Add missing/fix documentations in Client/Lib/Repo
......................................................................
Add missing/fix documentations in Client/Lib/Repo
This is a pure docs patch. Nothing functional is done here.
This is split from I04767f2.
Change-Id: I9cf89f306ed1960e1a3d95135a5239b4d4cdc8f7
---
M client/includes/Hooks/DataUpdateHookHandlers.php
M client/includes/Hooks/OtherProjectsSidebarGenerator.php
M client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php
M client/includes/Hooks/SidebarHookHandlers.php
M client/includes/scribunto/WikibaseLuaBindings.php
M client/tests/phpunit/includes/LangLinkHandlerTest.php
M lib/includes/serializers/SerializerFactory.php
M lib/includes/store/CachingPropertyInfoStore.php
M lib/includes/store/GenericEntityInfoBuilder.php
M lib/includes/store/sql/SqlEntityInfoBuilder.php
M repo/includes/EditEntity.php
M repo/includes/IO/LineReader.php
M repo/includes/LinkedData/EntityDataSerializationService.php
M repo/includes/specials/SpecialEntitiesWithoutPage.php
M repo/includes/specials/SpecialEntityData.php
M repo/includes/specials/SpecialNewEntity.php
M repo/includes/store/sql/SqlStore.php
M repo/maintenance/importInterlang.php
M repo/maintenance/importProperties.php
M repo/tests/phpunit/includes/Dumpers/JsonDumpGeneratorTest.php
M repo/tests/phpunit/includes/EntityModificationTestHelper.php
M repo/tests/phpunit/includes/Interactors/ItemMergeInteractorTest.php
M repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php
M repo/tests/phpunit/includes/UpdateRepo/UpdateRepoOnMoveJobTest.php
M repo/tests/phpunit/includes/View/ClaimsViewTest.php
M repo/tests/phpunit/includes/api/CreateRedirectModuleTest.php
M repo/tests/phpunit/includes/api/MergeItemsTest.php
M repo/tests/phpunit/includes/api/SetClaimValueTest.php
M repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
M repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php
30 files changed, 119 insertions(+), 69 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/45/185845/1
diff --git a/client/includes/Hooks/DataUpdateHookHandlers.php
b/client/includes/Hooks/DataUpdateHookHandlers.php
index 9287944..0f8e96f 100644
--- a/client/includes/Hooks/DataUpdateHookHandlers.php
+++ b/client/includes/Hooks/DataUpdateHookHandlers.php
@@ -132,7 +132,7 @@
/**
* Hook run after a page was deleted.
*
- * @param int $namespaceId
+ * @param int $namespace
* @param int $pageId
*/
public function doArticleDeleteComplete( $namespace, $pageId ) {
diff --git a/client/includes/Hooks/OtherProjectsSidebarGenerator.php
b/client/includes/Hooks/OtherProjectsSidebarGenerator.php
index 01b394e..32ff5a3 100644
--- a/client/includes/Hooks/OtherProjectsSidebarGenerator.php
+++ b/client/includes/Hooks/OtherProjectsSidebarGenerator.php
@@ -56,7 +56,7 @@
/**
* @param Title $title
*
- * @return array
+ * @return array[]
*/
public function buildProjectLinkSidebar( Title $title ) {
return $this->buildSidebarFromSiteLinks( $this->getSiteLinks(
$title ) );
@@ -65,7 +65,7 @@
/**
* @param SiteLink[] $siteLinks
*
- * @return array
+ * @return array[]
*/
private function buildSidebarFromSiteLinks( array $siteLinks ) {
$result = array();
@@ -85,6 +85,11 @@
return $result;
}
+ /**
+ * @param Title $title
+ *
+ * @return SiteLink[]
+ */
private function getSiteLinks( Title $title ) {
$siteLink = new SiteLink( $this->localSiteId,
$title->getFullText() );
$itemId = $this->siteLinkLookup->getEntityIdForSiteLink(
$siteLink );
@@ -96,6 +101,12 @@
return $this->siteLinkLookup->getSiteLinksForItem( $itemId );
}
+ /**
+ * @param SiteLink $siteLink
+ * @param Site $site
+ *
+ * @return string[]
+ */
private function buildSidebarLink( SiteLink $siteLink, Site $site ) {
$node = array(
'msg' => 'wikibase-otherprojects-' . $site->getGroup(),
@@ -110,4 +121,5 @@
return $node;
}
+
}
diff --git a/client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php
b/client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php
index c1ea182..567e59d 100644
--- a/client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php
+++ b/client/includes/Hooks/OtherProjectsSidebarGeneratorFactory.php
@@ -15,7 +15,7 @@
class OtherProjectsSidebarGeneratorFactory {
/**
- * @var OtherProjectsSidebarGenerator
+ * @var OtherProjectsSidebarGenerator|null
*/
private $otherProjectsSidebarGenerator = null;
diff --git a/client/includes/Hooks/SidebarHookHandlers.php
b/client/includes/Hooks/SidebarHookHandlers.php
index 375f82c..fec9054 100644
--- a/client/includes/Hooks/SidebarHookHandlers.php
+++ b/client/includes/Hooks/SidebarHookHandlers.php
@@ -49,7 +49,7 @@
private $otherProjectsLinksDefault;
/**
- * @var SidebarHookHandlers
+ * @var SidebarHookHandlers|null
*/
private static $instance = null;
diff --git a/client/includes/scribunto/WikibaseLuaBindings.php
b/client/includes/scribunto/WikibaseLuaBindings.php
index 1bea937..35ff565 100644
--- a/client/includes/scribunto/WikibaseLuaBindings.php
+++ b/client/includes/scribunto/WikibaseLuaBindings.php
@@ -89,7 +89,7 @@
private $usageAccumulator;
/**
- * @var SerializationOptions
+ * @var SerializationOptions|null
*/
private $serializationOptions = null;
diff --git a/client/tests/phpunit/includes/LangLinkHandlerTest.php
b/client/tests/phpunit/includes/LangLinkHandlerTest.php
index dea578b..54c1123 100644
--- a/client/tests/phpunit/includes/LangLinkHandlerTest.php
+++ b/client/tests/phpunit/includes/LangLinkHandlerTest.php
@@ -7,6 +7,7 @@
use Title;
use Wikibase\Client\Hooks\LanguageLinkBadgeDisplay;
use Wikibase\Client\Hooks\OtherProjectsSidebarGenerator;
+use Wikibase\Client\Hooks\OtherProjectsSidebarGeneratorFactory;
use Wikibase\Client\Usage\EntityUsage;
use Wikibase\Client\Usage\ParserOutputUsageAccumulator;
use Wikibase\DataModel\Entity\Item;
@@ -72,6 +73,11 @@
$this->langLinkHandler = $this->getLangLinkHandler( array() );
}
+ /**
+ * @param string[] $otherProjects
+ *
+ * @return LangLinkHandler
+ */
private function getLangLinkHandler( array $otherProjects ) {
$this->mockRepo = new MockRepository();
@@ -93,6 +99,11 @@
);
}
+ /**
+ * @param string[] $otherProjects
+ *
+ * @return OtherProjectsSidebarGeneratorFactory
+ */
private function getOtherProjectsSidebarGeneratorFactory( array
$otherProjects ) {
$otherProjectsSidebarGenerator =
$this->getOtherProjectsSidebarGenerator( $otherProjects );
@@ -110,7 +121,7 @@
}
/**
- * @param array $otherProjects
+ * @param string[] $otherProjects
*
* @return OtherProjectsSidebarGenerator
*/
diff --git a/lib/includes/serializers/SerializerFactory.php
b/lib/includes/serializers/SerializerFactory.php
index ed96965..d7ce5a8 100644
--- a/lib/includes/serializers/SerializerFactory.php
+++ b/lib/includes/serializers/SerializerFactory.php
@@ -28,17 +28,17 @@
class SerializerFactory {
/**
- * @var EntityFactory
+ * @var EntityFactory|null
*/
public $entityFactory = null;
/**
- * @var SiteStore
+ * @var SiteStore|null
*/
public $siteStore = null;
/**
- * @var PropertyDataTypeLookup
+ * @var PropertyDataTypeLookup|null
*/
protected $dataTypeLookup = null;
diff --git a/lib/includes/store/CachingPropertyInfoStore.php
b/lib/includes/store/CachingPropertyInfoStore.php
index d2e0074..79f9e60 100644
--- a/lib/includes/store/CachingPropertyInfoStore.php
+++ b/lib/includes/store/CachingPropertyInfoStore.php
@@ -39,7 +39,7 @@
/**
* Maps properties to info arrays
*
- * @var array[]
+ * @var array[]|null
*/
protected $propertyInfo = null;
diff --git a/lib/includes/store/GenericEntityInfoBuilder.php
b/lib/includes/store/GenericEntityInfoBuilder.php
index f2ca161..385dd32 100644
--- a/lib/includes/store/GenericEntityInfoBuilder.php
+++ b/lib/includes/store/GenericEntityInfoBuilder.php
@@ -29,7 +29,7 @@
*
* @see EntityInfoBuilder::getEntityInfo()
*
- * @var array[] map of id-strings to entity record arrays:
+ * @var array[]|null map of id-strings to entity record arrays:
* id-string => entity-record
*/
private $entityInfo = null;
@@ -50,7 +50,7 @@
*
* Initialized lazily by resolveRedirects().
*
- * @var string[] map of id-strings to EntityId objects:
+ * @var string[]|null map of id-strings to EntityId objects:
* id-string => EntityId
*/
private $redirects = null;
diff --git a/lib/includes/store/sql/SqlEntityInfoBuilder.php
b/lib/includes/store/sql/SqlEntityInfoBuilder.php
index 24cf39b..c951fa1 100644
--- a/lib/includes/store/sql/SqlEntityInfoBuilder.php
+++ b/lib/includes/store/sql/SqlEntityInfoBuilder.php
@@ -63,7 +63,7 @@
*
* @see getEntityId()
*
- * @var EntityId[] map of id-strings to EntityId objects: id-string =>
EntityId
+ * @var EntityId[]|null map of id-strings to EntityId objects:
id-string => EntityId
*/
private $entityIds = null;
@@ -75,7 +75,7 @@
*
* @see EntityInfoBuilder::getEntityInfo()
*
- * @var array[] map of id-strings to entity-record arrays:
+ * @var array[]|null map of id-strings to entity-record arrays:
* id-string => record
*/
private $entityInfo = null;
@@ -98,7 +98,7 @@
*
* Initialized lazily by getPageInfoIdsByType().
*
- * @var array[] map of entity type to maps of id-strings to numeric ids:
+ * @var array[]|null map of entity type to maps of id-strings to
numeric ids:
* type => id-string => id-int
*/
private $pageInfoByType = null;
@@ -109,7 +109,7 @@
*
* Initialized lazily by resolveRedirects().
*
- * @var string[] map of id-string to EntityId objects:
+ * @var string[]|null map of id-string to EntityId objects:
* id-string => EntityId
*/
private $redirects = null;
diff --git a/repo/includes/EditEntity.php b/repo/includes/EditEntity.php
index 9578e11..9fe1cd4 100644
--- a/repo/includes/EditEntity.php
+++ b/repo/includes/EditEntity.php
@@ -54,47 +54,47 @@
/**
* The modified entity we are trying to save
*
- * @var Entity
+ * @var Entity|null
*/
protected $newEntity = null;
/**
- * @var EntityRevision
+ * @var EntityRevision|null
*/
protected $baseRev = null;
/**
- * @var int
+ * @var int|null
*/
protected $baseRevId = null;
/**
- * @var EntityRevision
+ * @var EntityRevision|null
*/
protected $latestRev = null;
/**
- * @var int
+ * @var int|null
*/
protected $latestRevId = null;
/**
- * @var Status
+ * @var Status|null
*/
protected $status = null;
/**
- * @var User
+ * @var User|null
*/
protected $user = null;
/**
- * @var Title
+ * @var Title|null
*/
protected $title = null;
/**
- * @var IContextSource
+ * @var IContextSource|null
*/
protected $context = null;
diff --git a/repo/includes/IO/LineReader.php b/repo/includes/IO/LineReader.php
index 885df72..4115f95 100644
--- a/repo/includes/IO/LineReader.php
+++ b/repo/includes/IO/LineReader.php
@@ -36,7 +36,7 @@
protected $autoDispose;
/**
- * @var string
+ * @var string|null
*/
protected $current = null;
diff --git a/repo/includes/LinkedData/EntityDataSerializationService.php
b/repo/includes/LinkedData/EntityDataSerializationService.php
index ce8059b..9d6d258 100644
--- a/repo/includes/LinkedData/EntityDataSerializationService.php
+++ b/repo/includes/LinkedData/EntityDataSerializationService.php
@@ -41,7 +41,7 @@
/**
* White list of supported formats.
*
- * @var array
+ * @var array|null
*/
private $formatWhiteList = null;
@@ -62,17 +62,17 @@
);
/**
- * @var string
+ * @var string|null
*/
private $rdfBaseURI = null;
/**
- * @var string
+ * @var string|null
*/
private $rdfDataURI = null;
/**
- * @var EntityLookup
+ * @var EntityLookup|null
*/
private $entityLookup = null;
diff --git a/repo/includes/specials/SpecialEntitiesWithoutPage.php
b/repo/includes/specials/SpecialEntitiesWithoutPage.php
index 9975f0f..3eb9550 100644
--- a/repo/includes/specials/SpecialEntitiesWithoutPage.php
+++ b/repo/includes/specials/SpecialEntitiesWithoutPage.php
@@ -29,7 +29,7 @@
/**
* The type used
*
- * @var string
+ * @var string|null
*/
private $type = null;
diff --git a/repo/includes/specials/SpecialEntityData.php
b/repo/includes/specials/SpecialEntityData.php
index f9571fb..6d0523c 100644
--- a/repo/includes/specials/SpecialEntityData.php
+++ b/repo/includes/specials/SpecialEntityData.php
@@ -28,7 +28,7 @@
class SpecialEntityData extends SpecialWikibasePage {
/**
- * @var EntityDataRequestHandler
+ * @var EntityDataRequestHandler|null
*/
protected $requestHandler = null;
diff --git a/repo/includes/specials/SpecialNewEntity.php
b/repo/includes/specials/SpecialNewEntity.php
index d8254df..9575dce 100644
--- a/repo/includes/specials/SpecialNewEntity.php
+++ b/repo/includes/specials/SpecialNewEntity.php
@@ -26,17 +26,17 @@
/**
* Contains pieces of the sub-page name of this special page if a
subpage was called.
* E.g. array( 'a', 'b' ) in case of 'Special:NewEntity/a/b'
- * @var string[]
+ * @var string[]|null
*/
protected $parts = null;
/**
- * @var string
+ * @var string|null
*/
protected $label = null;
/**
- * @var string
+ * @var string|null
*/
protected $description = null;
diff --git a/repo/includes/store/sql/SqlStore.php
b/repo/includes/store/sql/SqlStore.php
index 12ad907..3f1bb49 100644
--- a/repo/includes/store/sql/SqlStore.php
+++ b/repo/includes/store/sql/SqlStore.php
@@ -43,37 +43,37 @@
class SqlStore implements Store {
/**
- * @var EntityRevisionLookup
+ * @var EntityRevisionLookup|null
*/
private $entityRevisionLookup = null;
/**
- * @var EntityRevisionLookup
+ * @var EntityRevisionLookup|null
*/
private $rawEntityRevisionLookup = null;
/**
- * @var EntityStore
+ * @var EntityStore|null
*/
private $entityStore = null;
/**
- * @var DispatchingEntityStoreWatcher
+ * @var DispatchingEntityStoreWatcher|null
*/
private $entityStoreWatcher = null;
/**
- * @var EntityInfoBuilderFactory
+ * @var EntityInfoBuilderFactory|null
*/
private $entityInfoBuilderFactory = null;
/**
- * @var PropertyInfoTable
+ * @var PropertyInfoTable|null
*/
private $propertyInfoTable = null;
/**
- * @var ChangesTable
+ * @var ChangesTable|null
*/
private $changesTable = null;
@@ -83,7 +83,7 @@
private $changesDatabase;
/**
- * @var TermIndex
+ * @var TermIndex|null
*/
private $termIndex = null;
@@ -119,6 +119,7 @@
/**
* @param EntityContentDataCodec $contentCodec
+ * @param EntityIdParser $entityIdParser
*/
public function __construct(
EntityContentDataCodec $contentCodec,
diff --git a/repo/maintenance/importInterlang.php
b/repo/maintenance/importInterlang.php
index 9237758..d51e119 100644
--- a/repo/maintenance/importInterlang.php
+++ b/repo/maintenance/importInterlang.php
@@ -30,12 +30,12 @@
protected $only = 0;
/**
- * @var User
+ * @var User|null
*/
protected $user = null;
/**
- * @var EntityStore
+ * @var EntityStore|null
*/
protected $store = null;
diff --git a/repo/maintenance/importProperties.php
b/repo/maintenance/importProperties.php
index 9f185f3..ea6bd25 100644
--- a/repo/maintenance/importProperties.php
+++ b/repo/maintenance/importProperties.php
@@ -31,12 +31,12 @@
protected $only = 0;
/**
- * @var User
+ * @var User|null
*/
protected $user = null;
/**
- * @var EntityStore
+ * @var EntityStore|null
*/
protected $store = null;
diff --git a/repo/tests/phpunit/includes/Dumpers/JsonDumpGeneratorTest.php
b/repo/tests/phpunit/includes/Dumpers/JsonDumpGeneratorTest.php
index 507a4e2..0d04636 100644
--- a/repo/tests/phpunit/includes/Dumpers/JsonDumpGeneratorTest.php
+++ b/repo/tests/phpunit/includes/Dumpers/JsonDumpGeneratorTest.php
@@ -31,12 +31,12 @@
class JsonDumpGeneratorTest extends \PHPUnit_Framework_TestCase {
/**
- * @var SerializerFactory
+ * @var SerializerFactory|null
*/
public $serializerFactory = null;
/**
- * @var SerializationOptions
+ * @var SerializationOptions|null
*/
public $serializationOptions = null;
diff --git a/repo/tests/phpunit/includes/EntityModificationTestHelper.php
b/repo/tests/phpunit/includes/EntityModificationTestHelper.php
index f397fc7..de52507 100644
--- a/repo/tests/phpunit/includes/EntityModificationTestHelper.php
+++ b/repo/tests/phpunit/includes/EntityModificationTestHelper.php
@@ -2,9 +2,12 @@
namespace Wikibase\Test;
+use Deserializers\Deserializer;
use PHPUnit_Framework_Assert as Assert;
+use Serializers\Serializer;
use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\DataModel\Entity\EntityIdParser;
use Wikibase\Lib\Store\EntityRedirect;
use Wikibase\Repo\WikibaseRepo;
@@ -16,12 +19,24 @@
*/
class EntityModificationTestHelper {
+ /**
+ * @var EntityIdParser
+ */
private $idParser;
+ /**
+ * @var Serializer
+ */
private $serializer;
+ /**
+ * @var Deserializer
+ */
private $deserializer;
+ /**
+ * @var MockRepository
+ */
private $repository;
public function __construct() {
diff --git
a/repo/tests/phpunit/includes/Interactors/ItemMergeInteractorTest.php
b/repo/tests/phpunit/includes/Interactors/ItemMergeInteractorTest.php
index 9811176..20f0c8c 100644
--- a/repo/tests/phpunit/includes/Interactors/ItemMergeInteractorTest.php
+++ b/repo/tests/phpunit/includes/Interactors/ItemMergeInteractorTest.php
@@ -30,12 +30,12 @@
class ItemMergeInteractorTest extends \PHPUnit_Framework_TestCase {
/**
- * @var MockRepository
+ * @var MockRepository|null
*/
private $repo = null;
/**
- * @var EntityModificationTestHelper
+ * @var EntityModificationTestHelper|null
*/
private $testHelper = null;
diff --git
a/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php
b/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php
index b83c8e6..dc13ce4 100644
--- a/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php
+++ b/repo/tests/phpunit/includes/Interactors/RedirectCreationInteractorTest.php
@@ -30,7 +30,7 @@
class RedirectCreationInteractorTest extends \PHPUnit_Framework_TestCase {
/**
- * @var MockRepository
+ * @var MockRepository|null
*/
private $repo = null;
diff --git a/repo/tests/phpunit/includes/UpdateRepo/UpdateRepoOnMoveJobTest.php
b/repo/tests/phpunit/includes/UpdateRepo/UpdateRepoOnMoveJobTest.php
index f1bc188..7ce773b 100644
--- a/repo/tests/phpunit/includes/UpdateRepo/UpdateRepoOnMoveJobTest.php
+++ b/repo/tests/phpunit/includes/UpdateRepo/UpdateRepoOnMoveJobTest.php
@@ -2,9 +2,9 @@
namespace Wikibase\Repo\Tests\UpdateRepo;
+use Status;
use Title;
use User;
-use Status;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\Repo\UpdateRepo\UpdateRepoOnMoveJob;
@@ -96,9 +96,8 @@
/**
* @dataProvider runProvider
- *
- * @param bool $expected
- * @param bool $titleExists
+ * @param string $expected
+ * @param string $normalizedPageName
* @param string $oldTitle
*/
public function testRun( $expected, $normalizedPageName, $oldTitle ) {
@@ -147,4 +146,5 @@
array( new ItemId( 'Q42' ) )
);
}
+
}
diff --git a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
index af01ad5..c9dc9cd 100644
--- a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
+++ b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
@@ -58,6 +58,11 @@
$this->assertContains( $link, $html );
}
+ /**
+ * @param PropertyId $propertyId
+ *
+ * @return Claim[]
+ */
private function makeClaims( PropertyId $propertyId ) {
$claims = array(
$this->makeClaim( new PropertyNoValueSnak(
@@ -87,6 +92,12 @@
return $claims;
}
+ /**
+ * @param Snak $mainSnak
+ * @param string|null $guid
+ *
+ * @return Claim
+ */
private function makeClaim( Snak $mainSnak, $guid = null ) {
static $guidCounter = 0;
diff --git a/repo/tests/phpunit/includes/api/CreateRedirectModuleTest.php
b/repo/tests/phpunit/includes/api/CreateRedirectModuleTest.php
index f3f1c43..ff3902f 100644
--- a/repo/tests/phpunit/includes/api/CreateRedirectModuleTest.php
+++ b/repo/tests/phpunit/includes/api/CreateRedirectModuleTest.php
@@ -35,7 +35,7 @@
class CreateRedirectModuleTest extends \PHPUnit_Framework_TestCase {
/**
- * @var MockRepository
+ * @var MockRepository|null
*/
private $repo = null;
diff --git a/repo/tests/phpunit/includes/api/MergeItemsTest.php
b/repo/tests/phpunit/includes/api/MergeItemsTest.php
index 73e9124..59360b9 100644
--- a/repo/tests/phpunit/includes/api/MergeItemsTest.php
+++ b/repo/tests/phpunit/includes/api/MergeItemsTest.php
@@ -29,17 +29,17 @@
class MergeItemsTest extends \PHPUnit_Framework_TestCase {
/**
- * @var MockRepository
+ * @var MockRepository|null
*/
private $repo = null;
/**
- * @var EntityModificationTestHelper
+ * @var EntityModificationTestHelper|null
*/
private $entityModificationTestHelper = null;
/**
- * @var ApiModuleTestHelper
+ * @var ApiModuleTestHelper|null
*/
private $apiModuleTestHelper = null;
diff --git a/repo/tests/phpunit/includes/api/SetClaimValueTest.php
b/repo/tests/phpunit/includes/api/SetClaimValueTest.php
index ffa5388..fc44c74 100644
--- a/repo/tests/phpunit/includes/api/SetClaimValueTest.php
+++ b/repo/tests/phpunit/includes/api/SetClaimValueTest.php
@@ -45,12 +45,12 @@
class SetClaimValueTest extends WikibaseApiTestCase {
/**
- * @var ValueFormatter
+ * @var ValueFormatter|null
*/
private $entityIdFormatter = null;
/**
- * @var ValueFormatter
+ * @var ValueFormatter|null
*/
private $propertyValueFormatter = null;
diff --git a/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
b/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
index 655b6c1..b28b302 100644
--- a/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
+++ b/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
@@ -33,17 +33,17 @@
class SpecialMergeItemsTest extends SpecialPageTestBase {
/**
- * @var MockRepository
+ * @var MockRepository|null
*/
private $repo = null;
/**
- * @var User
+ * @var User|null
*/
private $user = null;
/**
- * @var EntityModificationTestHelper
+ * @var EntityModificationTestHelper|null
*/
private $entityModificationTestHelper = null;
diff --git a/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php
b/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php
index d66cd0b..eda2f06 100644
--- a/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php
+++ b/repo/tests/phpunit/includes/specials/SpecialSetSitelinkTest.php
@@ -62,17 +62,17 @@
);
/**
- * @var string
+ * @var string|null
*/
private static $itemId = null;
/**
- * @var string
+ * @var string|null
*/
private static $badgeId = null;
/**
- * @var string
+ * @var string|null
*/
private static $redirectId = null;
--
To view, visit https://gerrit.wikimedia.org/r/185845
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cf89f306ed1960e1a3d95135a5239b4d4cdc8f7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
