Christopher Johnson (WMDE) has submitted this change and it was merged.
Change subject: remove name validation unit tests
......................................................................
remove name validation unit tests
Change-Id: I12ddc014b1de9f508509cd9f1573756bf64bdd4b
---
M src/constants/SprintConstants.php
M src/tests/SprintCustomFieldTest.php
M src/tests/SprintTestCase.php
3 files changed, 7 insertions(+), 24 deletions(-)
Approvals:
Christopher Johnson (WMDE): Verified; Looks good to me, approved
diff --git a/src/constants/SprintConstants.php
b/src/constants/SprintConstants.php
index 1bee05d..8c22100 100644
--- a/src/constants/SprintConstants.php
+++ b/src/constants/SprintConstants.php
@@ -8,5 +8,4 @@
const ROOT_DIR = '/srv/phab';
const POINTFIELD_INDEX = 'yERhvoZPNPtM';
const SPRINTFIELD_INDEX = 'scsOmkpB9Tqi';
-}
-
+}
diff --git a/src/tests/SprintCustomFieldTest.php
b/src/tests/SprintCustomFieldTest.php
index bd659ed..61a9f96 100644
--- a/src/tests/SprintCustomFieldTest.php
+++ b/src/tests/SprintCustomFieldTest.php
@@ -110,23 +110,6 @@
$this->assertEquals('AphrontFormDateControl', get_class($control));
}
- public function testcheckForSprint() {
- $validator = new SprintValidator();
- $mword = SprintConstants::MAGIC_WORD;
- $showfields = array($validator, 'shouldShowSprintFields');
- $project = id(new PhabricatorProject())->setName($mword.'Test');
- $is_sprint = $validator->checkForSprint($showfields, $project);
- $this->assertTrue($is_sprint);
- }
-
- public function testcheckForNonSprint() {
- $validator = new SprintValidator();
- $showfields = array($validator, 'shouldShowSprintFields');
- $project = id(new PhabricatorProject())->setName('Test');
- $is_sprint = $validator->checkForSprint($showfields, $project);
- $this->assertFalse($is_sprint);
- }
-
public function testrenderDateProxyPropertyViewValue()
{
$classname = 'SprintProjectCustomField';
@@ -201,4 +184,4 @@
$this->assertEquals('project', $value);
}
-}
\ No newline at end of file
+}
diff --git a/src/tests/SprintTestCase.php b/src/tests/SprintTestCase.php
index 98f55af..6c5f4da 100644
--- a/src/tests/SprintTestCase.php
+++ b/src/tests/SprintTestCase.php
@@ -45,7 +45,7 @@
private function getComputedConfiguration() {
$config = $this->getPhabricatorTestCaseConfiguration() + array(
- self::PHABRICATOR_TESTCONFIG_ISOLATE_LISK => true,
+ self::PHABRICATOR_TESTCONFIG_ISOLATE_LISK => false,
self::PHABRICATOR_TESTCONFIG_BUILD_STORAGE_FIXTURES => false,
);
@@ -91,7 +91,8 @@
LiskDAO::beginIsolateAllLiskEffectsToCurrentProcess();
}
- $this->env = PhabricatorEnv::beginScopedEnv();
+// $this->env = new PhabricatorEnv();
+// $this->env->initializeWebEnvironment();
// NOTE: While running unit tests, we act as though all applications are
// installed, regardless of the install's configuration. Tests which need
@@ -140,7 +141,7 @@
}
}
- protected function willRunOneTest($test) {
+ protected function willRunOneTest() {
$config = $this->getComputedConfiguration();
if ($config[self::PHABRICATOR_TESTCONFIG_BUILD_STORAGE_FIXTURES]) {
@@ -212,4 +213,4 @@
}
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/185985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12ddc014b1de9f508509cd9f1573756bf64bdd4b
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
Gerrit-Reviewer: Christopher Johnson (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
