jenkins-bot has submitted this change and it was merged.

Change subject: UserLogin: Don't rely on jQuery prop('tabindex') to map to 
tabIndex
......................................................................


UserLogin: Don't rely on jQuery prop('tabindex') to map to tabIndex

Follows-up I9b03d519af43d.

There is a hardcoded set of exceptions in jQuery core right now
that map these common mistakes for back-compat. But this is
undocumented/unsupported legacy behaviour for a very small subset
of properties.

Change-Id: I9cfef0bc6a088e4c0a632b3673df460d26477c37
---
M resources/src/mediawiki.special/mediawiki.special.userlogin.common.js
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git 
a/resources/src/mediawiki.special/mediawiki.special.userlogin.common.js 
b/resources/src/mediawiki.special/mediawiki.special.userlogin.common.js
index 247f814..f5289de 100644
--- a/resources/src/mediawiki.special/mediawiki.special.userlogin.common.js
+++ b/resources/src/mediawiki.special/mediawiki.special.userlogin.common.js
@@ -20,7 +20,7 @@
                if ( !$submit.length ) {
                        return;
                }
-               tabIndex = $submit.prop( 'tabindex' ) - 1;
+               tabIndex = $submit.prop( 'tabIndex' ) - 1;
                $captchaStuff = $content.find( '.captcha' );
 
                if ( $captchaStuff.length ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/186092
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9cfef0bc6a088e4c0a632b3673df460d26477c37
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to