Yaron Koren has submitted this change and it was merged.
Change subject: HTML and formatting improvements
......................................................................
HTML and formatting improvements
Change-Id: I3af283a18910d54020ef5386bb552fca4abd805e
---
M specials/SF_CreateTemplate.php
1 file changed, 11 insertions(+), 8 deletions(-)
Approvals:
Yaron Koren: Checked; Looks good to me, approved
diff --git a/specials/SF_CreateTemplate.php b/specials/SF_CreateTemplate.php
index b8cf60b..f4569a5 100644
--- a/specials/SF_CreateTemplate.php
+++ b/specials/SF_CreateTemplate.php
@@ -84,25 +84,28 @@
public static function printFieldEntryBox( $id, $all_properties,
$display = true ) {
$fieldString = $display ? '' : 'id="starterField"
style="display: none"';
$text = "\t<div class=\"fieldBox\" $fieldString>\n";
- $text .= "\t<p>" . wfMessage( 'sf_createtemplate_fieldname'
)->text() . ' ' .
+ $text .= "\t<table style=\"width: 100%;\"><tr><td>\n";
+ $text .= "\t<p><label>" . wfMessage(
'sf_createtemplate_fieldname' )->text() . ' ' .
Html::input( 'name_' . $id, null, 'text',
array( 'size' => '15' )
- ) . "\n";
- $text .= "\t" . wfMessage( 'sf_createtemplate_displaylabel'
)->text() . ' ' .
+ ) . "</label> \n";
+ $text .= "\t<label>" . wfMessage(
'sf_createtemplate_displaylabel' )->text() . ' ' .
Html::input( 'label_' . $id, null, 'text',
array( 'size' => '15' )
- ) . "\n";
+ ) . "</label> \n";
if ( defined( 'SMW_VERSION' ) ) {
$dropdown_html = self::printPropertiesComboBox(
$all_properties, $id );
- $text .= "\t" . wfMessage(
'sf_createtemplate_semanticproperty' )->text() . ' ' . $dropdown_html .
"</p>\n";
+ $text .= "\t<label>" . wfMessage(
'sf_createtemplate_semanticproperty' )->text() . ' ' . $dropdown_html .
"</label></p>\n";
}
- $text .= "\t<p>" . '<input type="checkbox" name="is_list_' .
$id . '" /> ' . wfMessage( 'sf_createtemplate_fieldislist' )->text() . "\n";
- $text .= '   <input type="button" value="' .
wfMessage( 'sf_createtemplate_deletefield' )->text() . '" class="deleteField"
/>' . "\n";
+ $text .= "\t<p>" . '<label><input type="checkbox"
name="is_list_' . $id . '" /> ' . wfMessage( 'sf_createtemplate_fieldislist'
)->text() . "</label>\n";
+ $text .= "\t</p>\n";
+ $text .= "\t</td><td>\n";
+ $text .= "\t" . '<input type="button" value="' . wfMessage(
'sf_createtemplate_deletefield' )->text() . '" class="deleteField" />' . "\n";
$text .= <<<END
-</p>
+</td></tr></table>
</div>
END;
--
To view, visit https://gerrit.wikimedia.org/r/186093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3af283a18910d54020ef5386bb552fca4abd805e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
