Adamw has submitted this change and it was merged. Change subject: CentralNotice bugfix for Bugzilla #41862 ......................................................................
CentralNotice bugfix for Bugzilla #41862 Floating point error was catching us out near slot boundries. This new algorithm attempts to minimize FP error by sticking to integer math where possible. This specifically fixes a case of 5 banners with 1/5 allocation. Change-Id: Ia02e0163fe9aa057219b6e5513e61cb31e5d0444 --- M includes/BannerChooser.php 1 file changed, 21 insertions(+), 19 deletions(-) Approvals: Adamw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32317 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia02e0163fe9aa057219b6e5513e61cb31e5d0444 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Mwalker <[email protected]> Gerrit-Reviewer: Adamw <[email protected]> Gerrit-Reviewer: Mwalker <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
