jenkins-bot has submitted this change and it was merged.
Change subject: Use array_merge instead of += as the latter doesn't always work
......................................................................
Use array_merge instead of += as the latter doesn't always work
In plus, existing keys have precedence. So many of the tests
and up not being registered or run.
Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
---
M EventLogging.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/EventLogging.php b/EventLogging.php
index 94f294c..7b4b174 100644
--- a/EventLogging.php
+++ b/EventLogging.php
@@ -219,6 +219,6 @@
// Unit Tests
$wgHooks[ 'UnitTestsList' ][] = function ( &$files ) {
- $files += glob( __DIR__ . '/tests/*Test.php' );
+ $files = array_merge( $files, glob( __DIR__ . '/tests/*Test.php' ) );
return true;
};
--
To view, visit https://gerrit.wikimedia.org/r/186105
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
