jenkins-bot has submitted this change and it was merged.
Change subject: Increase encapsulation and decrease width of used interface
......................................................................
Increase encapsulation and decrease width of used interface
Change-Id: Id2888e9ee938ff48af0aa0f487e1df730933de22
---
M repo/includes/api/EditEntity.php
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/api/EditEntity.php b/repo/includes/api/EditEntity.php
index 40fdc2b..313e722 100644
--- a/repo/includes/api/EditEntity.php
+++ b/repo/includes/api/EditEntity.php
@@ -19,6 +19,7 @@
use Wikibase\ChangeOp\SiteLinkChangeOpFactory;
use Wikibase\DataModel\Claim\Claim;
use Wikibase\DataModel\Entity\Entity;
+use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\Property;
@@ -563,10 +564,10 @@
* @since 0.4
*
* @param mixed $data
- * @param Entity $entity
+ * @param EntityDocument $entity
* @param int $revId
*/
- protected function validateDataProperties( $data, Entity $entity,
$revId = 0 ) {
+ private function validateDataProperties( $data, EntityDocument $entity,
$revId = 0 ) {
$entityId = $entity->getId();
$title = $entityId === null ? null :
$this->getTitleLookup()->getTitleForId( $entityId );
@@ -702,7 +703,7 @@
}
}
- private function checkEntityType( $data, Entity $entity ) {
+ private function checkEntityType( $data, EntityDocument $entity ) {
if ( isset( $data['type'] )
&& $entity->getType() !== $data['type'] ) {
$this->dieError(
--
To view, visit https://gerrit.wikimedia.org/r/186118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id2888e9ee938ff48af0aa0f487e1df730933de22
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
