jenkins-bot has submitted this change and it was merged.
Change subject: Remove dead code
......................................................................
Remove dead code
This method can no longer return false since DM 2.0 (or 1.0, can't remember)
Change-Id: I790c62f59f00d4ceea619d46abaf41af78c3523d
---
M repo/includes/specials/SpecialNewItem.php
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/specials/SpecialNewItem.php
b/repo/includes/specials/SpecialNewItem.php
index 0d29cc0..61d34f6 100644
--- a/repo/includes/specials/SpecialNewItem.php
+++ b/repo/includes/specials/SpecialNewItem.php
@@ -81,13 +81,7 @@
return $status;
}
- $link = new SiteLink( $site->getGlobalId(), $page );
- $ret = $item->addSiteLink( $link );
-
- if ( $ret === false ) {
- $status->error(
'wikibase-newitem-add-sitelink-failed' );
- return $status;
- }
+ $item->getSiteLinkList()->addNewSiteLink(
$site->getGlobalId(), $page );
}
return $status;
--
To view, visit https://gerrit.wikimedia.org/r/186123
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I790c62f59f00d4ceea619d46abaf41af78c3523d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
