Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186256
Change subject: Stop using deprecated method
......................................................................
Stop using deprecated method
Change-Id: Ie3b54ee0c732b4ca7cd93fa365bc096ef115df61
---
M repo/includes/api/LinkTitles.php
M repo/includes/content/ItemContent.php
M repo/includes/content/ItemHandler.php
M repo/includes/specials/SpecialNewItem.php
4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/56/186256/1
diff --git a/repo/includes/api/LinkTitles.php b/repo/includes/api/LinkTitles.php
index 99e874e..01282e9 100644
--- a/repo/includes/api/LinkTitles.php
+++ b/repo/includes/api/LinkTitles.php
@@ -100,7 +100,7 @@
// Figure out which parts to use and what to create anew
if ( $fromId === null && $toId === null ) {
// create new item
- $item = Item::newEmpty();
+ $item = new Item();
$toLink = new SiteLink( $toSite->getGlobalId(), $toPage
);
$item->addSiteLink( $toLink );
$return[] = $toLink;
diff --git a/repo/includes/content/ItemContent.php
b/repo/includes/content/ItemContent.php
index c35f5e7..417faf7 100644
--- a/repo/includes/content/ItemContent.php
+++ b/repo/includes/content/ItemContent.php
@@ -169,7 +169,7 @@
* @return ItemContent
*/
public static function newEmpty() {
- return new static( new EntityInstanceHolder( Item::newEmpty() )
);
+ return new static( new EntityInstanceHolder( new Item() ) );
}
/**
diff --git a/repo/includes/content/ItemHandler.php
b/repo/includes/content/ItemHandler.php
index 1bef2f8..6b47c0e 100644
--- a/repo/includes/content/ItemHandler.php
+++ b/repo/includes/content/ItemHandler.php
@@ -174,7 +174,7 @@
* @return EntityContent
*/
public function makeEmptyEntity() {
- return Item::newEmpty();
+ return new Item();
}
/**
diff --git a/repo/includes/specials/SpecialNewItem.php
b/repo/includes/specials/SpecialNewItem.php
index 61d34f6..4d2fce5 100644
--- a/repo/includes/specials/SpecialNewItem.php
+++ b/repo/includes/specials/SpecialNewItem.php
@@ -52,7 +52,7 @@
* @return Item
*/
protected function createEntity() {
- return Item::newEmpty();
+ return new Item();
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/186256
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3b54ee0c732b4ca7cd93fa365bc096ef115df61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
