jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.inspect: Use fixed numbers for sizes in bytes
......................................................................
mediawiki.inspect: Use fixed numbers for sizes in bytes
Change-Id: Ieb39322ccfbbc80213ecd1d2a3b4f66bbe346b85
---
M resources/src/mediawiki/mediawiki.inspect.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.inspect.js
b/resources/src/mediawiki/mediawiki.inspect.js
index 4f02e06..3ad2be5 100644
--- a/resources/src/mediawiki/mediawiki.inspect.js
+++ b/resources/src/mediawiki/mediawiki.inspect.js
@@ -21,7 +21,9 @@
if ( !$.isNumeric( bytes ) || bytes === 0 ) { return bytes; }
var i = 0, units = [ '', ' kB', ' MB', ' GB', ' TB', ' PB' ];
for ( ; bytes >= 1024; bytes /= 1024 ) { i++; }
- return bytes.toFixed( 1 ) + units[i];
+ // Maintain one decimal for kB and above, but don't
+ // add ".0" for bytes.
+ return bytes.toFixed( i > 0 ? 1 : 0 ) + units[i];
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/179453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb39322ccfbbc80213ecd1d2a3b4f66bbe346b85
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
