Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186379
Change subject: v8 opt: enable optimisation for EventEmitter.emit
......................................................................
v8 opt: enable optimisation for EventEmitter.emit
Follows I4a0cf76f6.
Change-Id: I66501548b2ec96d050852d878e23aa47739b138f
---
M src/EventEmitter.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/79/186379/1
diff --git a/src/EventEmitter.js b/src/EventEmitter.js
index 12a90e8..d28d156 100644
--- a/src/EventEmitter.js
+++ b/src/EventEmitter.js
@@ -165,7 +165,9 @@
if ( hasOwn.call( this.bindings, event ) ) {
// Slicing ensures that we don't get tripped up by
event handlers that add/remove bindings
bindings = this.bindings[event].slice();
- args = Array.prototype.slice.call( arguments, 1 );
+ for ( i = 1, len = arguments.length; i < len; i++ ) {
+ args.push( arguments[i] );
+ }
for ( i = 0, len = bindings.length; i < len; i++ ) {
binding = bindings[i];
if ( typeof binding.method === 'string' ) {
--
To view, visit https://gerrit.wikimedia.org/r/186379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66501548b2ec96d050852d878e23aa47739b138f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
