John Erling Blad has submitted this change and it was merged. Change subject: Make ApiBotEditTest robust agnst non-sequential IDs. ......................................................................
Make ApiBotEditTest robust agnst non-sequential IDs. ApiBotEditTest was assuming that IDs of consecutively created items would be consecutive integers. This is not guaranteed, and frequently not true in the presence of blacklisted IDs. This change also fixes a problem with interpreting the recentchanges feed returned by the API: the latest edit is not necessarily the first rc entry returned by the API, because the order of edits that were done in the same second is undefined. Patchset 7: Did a rebase before submitting Change-Id: I6ec7a388a116e56c5471d761d8a9611fa98b26a8 --- M repo/tests/phpunit/includes/api/ApiBotEditTest.php 1 file changed, 52 insertions(+), 21 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30963 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ec7a388a116e56c5471d761d8a9611fa98b26a8 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Anja Jentzsch <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Jens Ohlig <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
