Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186755
Change subject: SnakTypeSelector: Remove 'javascript:void(0);' href
......................................................................
SnakTypeSelector: Remove 'javascript:void(0);' href
_58090
Change-Id: I97fed22b3666e610dd4cd2c7d8e71c3ea5459b4e
---
M lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
M
lib/resources/jquery.wikibase/snakview/themes/default/snakview.SnakTypeSelector.css
2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/55/186755/1
diff --git
a/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
b/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
index 1df67eb..c70ab8d 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.SnakTypeSelector.js
@@ -183,7 +183,7 @@
$( '<li/>' )
.addClass( classPrefix + type ) // type
should only be lower case string anyhow!
.data(
'snaktypeselector-menuitem-type', type )
- .append( $( '<a/>' ).attr( 'href',
'javascript:void(0);' ).text(
+ .append( $( '<a/>' ).text(
mw.msg(
'wikibase-snakview-snaktypeselector-' + type )
) )
);
diff --git
a/lib/resources/jquery.wikibase/snakview/themes/default/snakview.SnakTypeSelector.css
b/lib/resources/jquery.wikibase/snakview/themes/default/snakview.SnakTypeSelector.css
index f4e8d46..648f03f 100644
---
a/lib/resources/jquery.wikibase/snakview/themes/default/snakview.SnakTypeSelector.css
+++
b/lib/resources/jquery.wikibase/snakview/themes/default/snakview.SnakTypeSelector.css
@@ -21,3 +21,7 @@
position: absolute;
z-index: 2; /* Monobook #content has 2 */
}
+
+.wb-snaktypeselector-menu li a {
+ cursor: pointer;
+}
--
To view, visit https://gerrit.wikimedia.org/r/186755
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97fed22b3666e610dd4cd2c7d8e71c3ea5459b4e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
