jenkins-bot has submitted this change and it was merged.
Change subject: Special:AllMessages: Ignore case of first letter when sorting
......................................................................
Special:AllMessages: Ignore case of first letter when sorting
When a message key is defined with a upper case letter the sorting in
Special:AllMessages gets confused, because the upper case letter is
sorted before the lower case letters. Doing the upper case first, than
sorting avoids this when having such a key.
Bug: T86139
Change-Id: I8e9f7ca276a2fa999d8bd41c948cc083964ec66d
---
M includes/specials/SpecialAllMessages.php
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialAllMessages.php
b/includes/specials/SpecialAllMessages.php
index 7cf94cc..0008b10 100644
--- a/includes/specials/SpecialAllMessages.php
+++ b/includes/specials/SpecialAllMessages.php
@@ -224,14 +224,15 @@
function getAllMessages( $descending ) {
$messageNames =
Language::getLocalisationCache()->getSubitemList( 'en', 'messages' );
+
+ // Normalise message names so they look like page titles and
sort correctly - T86139
+ $messageNames = array_map( array( $this->lang, 'ucfirst' ),
$messageNames );
+
if ( $descending ) {
rsort( $messageNames );
} else {
asort( $messageNames );
}
-
- // Normalise message names so they look like page titles
- $messageNames = array_map( array( $this->lang, 'ucfirst' ),
$messageNames );
return $messageNames;
}
--
To view, visit https://gerrit.wikimedia.org/r/186584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e9f7ca276a2fa999d8bd41c948cc083964ec66d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
