Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187294
Change subject: Hygiene: Clean up repeated copies and re-assignments in
Resources.php
......................................................................
Hygiene: Clean up repeated copies and re-assignments in Resources.php
Follows-up 5c14e877e, which added two copy actions instead of one
chain. Previously built upon in 3d08f679 and e7c2c8e1a.
Instead of re-creating the variable four times and copying the value
several times in array_merge. Just copy it once, and mix in values
from the other arrays in one merge loop.
Change-Id: I8f75da1711bf56ef081166f798c4a6c9a597c032
---
M includes/Resources.php
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/94/187294/1
diff --git a/includes/Resources.php b/includes/Resources.php
index 683db00..8d88d7c 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -1674,10 +1674,12 @@
),
);
-$wgResourceModules = array_merge( $wgResourceModules,
$wgMobileSpecialPageModules );
-$wgResourceModules = array_merge( $wgResourceModules,
$wgMinervaSpecialPageModules );
-$wgResourceModules = array_merge( $wgResourceModules, $wgMinervaStyleModules );
-$wgResourceModules = array_merge( $wgResourceModules,
$wgMinervaBootstrapModules );
+$wgResourceModules = array_merge( $wgResourceModules,
+ $wgMobileSpecialPageModules,
+ $wgMinervaSpecialPageModules,
+ $wgMinervaStyleModules,
+ $wgMinervaBootstrapModules
+);
// Module customizations
$wgResourceModuleSkinStyles['default'] = $wgMFResourceBoilerplate + array(
--
To view, visit https://gerrit.wikimedia.org/r/187294
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f75da1711bf56ef081166f798c4a6c9a597c032
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
