jenkins-bot has submitted this change and it was merged.
Change subject: TextInputWidget: Remove superfluous role=textbox
......................................................................
TextInputWidget: Remove superfluous role=textbox
The wrapped <input> and <textarea> already have native text roles, so
no additional role is required here.
Bug: T87830
Change-Id: I710297d38d9b7546c58089db8aa5e39183841843
---
M src/widgets/TextInputWidget.js
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js
index 116a354..7f8a501 100644
--- a/src/widgets/TextInputWidget.js
+++ b/src/widgets/TextInputWidget.js
@@ -73,7 +73,6 @@
if ( config.autofocus ) {
this.$input.attr( 'autofocus', 'autofocus' );
}
- this.$element.attr( 'role', 'textbox' );
};
/* Setup */
--
To view, visit https://gerrit.wikimedia.org/r/187298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I710297d38d9b7546c58089db8aa5e39183841843
Gerrit-PatchSet: 4
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits