Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187313
Change subject: ve.ce.LinkAnnotation: Use getResolvedAttribute for href
......................................................................
ve.ce.LinkAnnotation: Use getResolvedAttribute for href
Instead of ve.resolveUrl(), getHref() and getModelHtmlDocument()
Change-Id: Ic5685be0b3cd5ba7f10f3cfa5c300c31b54dac29
---
M src/ce/annotations/ve.ce.LinkAnnotation.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/13/187313/1
diff --git a/src/ce/annotations/ve.ce.LinkAnnotation.js
b/src/ce/annotations/ve.ce.LinkAnnotation.js
index d7a0ac4..b198664 100644
--- a/src/ce/annotations/ve.ce.LinkAnnotation.js
+++ b/src/ce/annotations/ve.ce.LinkAnnotation.js
@@ -22,7 +22,7 @@
this.$element
.addClass( 've-ce-linkAnnotation' )
.prop( {
- href: ve.resolveUrl( this.model.getHref(),
this.getModelHtmlDocument() ),
+ href: this.getResolvedAttribute( 'href' ),
title: this.constructor.static.getDescription(
this.model )
} )
// Some browsers will try to let links do their thing
--
To view, visit https://gerrit.wikimedia.org/r/187313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5685be0b3cd5ba7f10f3cfa5c300c31b54dac29
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
