jenkins-bot has submitted this change and it was merged.
Change subject: Fixed sitelinklistview QUnit test
......................................................................
Fixed sitelinklistview QUnit test
As of change Iee90bfa54e8fdb0692d4bbe21ef2fd2d60aaccb8, sitelinklistview
encapsulates its
listview using TemplatedWidget's "encapsulate" option. Hence, listview events
should not
bubble up to the sitelinklistview node anymore.
Change-Id: I0a325f639dccd0dfee61c5de83ba75f763ebc787
---
M lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
1 file changed, 10 insertions(+), 2 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
index 968e9e9..da52e4b 100644
--- a/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
+++ b/lib/tests/qunit/jquery.wikibase/jquery.wikibase.sitelinklistview.tests.js
@@ -354,11 +354,19 @@
var $sitelinklistview = createSitelinklistview(),
sitelinklistview = $sitelinklistview.data( 'sitelinklistview' );
+ sitelinklistview.$listview
+ .on( 'listviewenternewitem', function() {
+ assert.ok(
+ true,
+ 'Triggered listview\'s "enternewitem" event on the
listview node.'
+ );
+ } );
+
$sitelinklistview
.on( 'listviewenternewitem', function( event, $sitelinkview ) {
assert.ok(
- true,
- 'Added listview item.'
+ false,
+ 'Triggered listview\'s "enternewitem" event on the
sitelinklistview node.'
);
} )
.on( 'sitelinklistviewafterstartediting', function() {
--
To view, visit https://gerrit.wikimedia.org/r/187342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a325f639dccd0dfee61c5de83ba75f763ebc787
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
