jenkins-bot has submitted this change and it was merged.
Change subject: Drop dead code from snakview.variations.Value
......................................................................
Drop dead code from snakview.variations.Value
See I0600d91. I decided to not do explicit null checks in favor of
simple comparisons (they are much more common in JS than they are in
PHP) because the data type is either a string or not. There is no
difference between it being null or false.
Change-Id: Id438672a407154f3018bd0bfdc1ea8af6dec57c1
---
M lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Adrian Lang: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
b/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
index a876097..cf7b40b 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.variations.Value.js
@@ -186,7 +186,6 @@
&& ( dataType || newValue !==
null )
) {
// display current Snak's data
value in existing valueview:
- self._valueView.option( 'on',
dataType );
self._valueView.value( newValue
);
} else {
// remove old view, create a
new one or display message if unsupported data
--
To view, visit https://gerrit.wikimedia.org/r/187363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id438672a407154f3018bd0bfdc1ea8af6dec57c1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.he...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
