Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187405
Change subject: ReplacementArray: Set explicit visiblity on functions
......................................................................
ReplacementArray: Set explicit visiblity on functions
Also add a type-hint
Change-Id: I78a322dfa11a71e22a3d0b7064b808aec6bfbf83
---
M includes/libs/ReplacementArray.php
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/05/187405/1
diff --git a/includes/libs/ReplacementArray.php
b/includes/libs/ReplacementArray.php
index 8c8c010..7fdb309 100644
--- a/includes/libs/ReplacementArray.php
+++ b/includes/libs/ReplacementArray.php
@@ -31,18 +31,18 @@
* The array should have the same form as the replacement array for
strtr()
* @param array $data
*/
- function __construct( $data = array() ) {
+ public function __construct( $data = array() ) {
$this->data = $data;
}
/**
* @return array
*/
- function __sleep() {
+ public function __sleep() {
return array( 'data' );
}
- function __wakeup() {
+ public function __wakeup() {
$this->fss = false;
}
@@ -50,7 +50,7 @@
* Set the whole replacement array at once
* @param array $data
*/
- function setArray( $data ) {
+ public function setArray( $data ) {
$this->data = $data;
$this->fss = false;
}
@@ -58,7 +58,7 @@
/**
* @return array|bool
*/
- function getArray() {
+ public function getArray() {
return $this->data;
}
@@ -67,7 +67,7 @@
* @param string $from
* @param string $to
*/
- function setPair( $from, $to ) {
+ public function setPair( $from, $to ) {
$this->data[$from] = $to;
$this->fss = false;
}
@@ -75,7 +75,7 @@
/**
* @param array $data
*/
- function mergeArray( $data ) {
+ public function mergeArray( $data ) {
$this->data = array_merge( $this->data, $data );
$this->fss = false;
}
@@ -83,7 +83,7 @@
/**
* @param ReplacementArray $other
*/
- function merge( $other ) {
+ public function merge( ReplacementArray $other ) {
$this->data = array_merge( $this->data, $other->data );
$this->fss = false;
}
@@ -91,7 +91,7 @@
/**
* @param string $from
*/
- function removePair( $from ) {
+ public function removePair( $from ) {
unset( $this->data[$from] );
$this->fss = false;
}
@@ -99,7 +99,7 @@
/**
* @param array $data
*/
- function removeArray( $data ) {
+ public function removeArray( $data ) {
foreach ( $data as $from => $to ) {
$this->removePair( $from );
}
@@ -110,7 +110,7 @@
* @param string $subject
* @return string
*/
- function replace( $subject ) {
+ public function replace( $subject ) {
if ( function_exists( 'fss_prep_replace' ) ) {
if ( $this->fss === false ) {
$this->fss = fss_prep_replace( $this->data );
--
To view, visit https://gerrit.wikimedia.org/r/187405
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I78a322dfa11a71e22a3d0b7064b808aec6bfbf83
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
