Hello Ottomata,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/187420
to review the following change.
Change subject: Separate different datasets better in webrequest dump script
......................................................................
Separate different datasets better in webrequest dump script
Change-Id: I7d695b4fc999ac20d6d1c205482b71a820123055
---
M bin/refinery-dump-status-webrequest-partitions
1 file changed, 8 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/refinery
refs/changes/20/187420/1
diff --git a/bin/refinery-dump-status-webrequest-partitions
b/bin/refinery-dump-status-webrequest-partitions
index cf15e90..14a7c52 100755
--- a/bin/refinery-dump-status-webrequest-partitions
+++ b/bin/refinery-dump-status-webrequest-partitions
@@ -176,7 +176,7 @@
hline() {
local KIND="$1"
- log_no_lf " +------------------+"
+ log_no_lf " ++------------------++"
for DATASET in "${ALL_DATASETS[@]}"
do
if [ "${DATASET_VISIBILITIES["$DATASET"]}" = "yes" ]
@@ -186,7 +186,7 @@
then
DATASET_HLINE="${DATASET_HLINE//+-/--}"
fi
- log_no_lf "${DATASET_HLINE}"
+ log_no_lf "${DATASET_HLINE}+"
fi
done
log
@@ -195,7 +195,7 @@
first_caption_line() {
local DATASET
- log_no_lf " | |"
+ log_no_lf " || ||"
for DATASET in "${ALL_DATASETS[@]}"
do
if [ "${DATASET_VISIBILITIES["$DATASET"]}" = "yes" ]
@@ -203,7 +203,7 @@
local DATASET_CAPTION="${DATASET_CAPTIONS["$DATASET"]}"
local DATASET_CAPTION_LEN="${#DATASET_CAPTION}"
log_no_lf_centered "$DATASET" $((DATASET_CAPTION_LEN-1))
- log_no_lf "|"
+ log_no_lf "||"
fi
done
log
@@ -212,12 +212,13 @@
second_caption_line() {
local DATASET
- log_no_lf " | Hour |"
+ log_no_lf " || Hour ||"
for DATASET in "${ALL_DATASETS[@]}"
do
if [ "${DATASET_VISIBILITIES["$DATASET"]}" = "yes" ]
then
log_no_lf "${DATASET_CAPTIONS["$DATASET"]}"
+ log_no_lf "|"
fi
done
log
@@ -328,12 +329,13 @@
for HOURS_OFFSET in $(seq $HOUR_OFFSET_MAX -1 $HOUR_OFFSET_MIN )
do
DATE="$(date --utc -d "$HOURS_OFFSET hours-ago" +'%Y-%m-%d %H')"
- log_no_lf " | ${DATE// /T}/1H |"
+ log_no_lf " || ${DATE// /T}/1H ||"
for DATASET in "${ALL_DATASETS[@]}"
do
if [ "${DATASET_VISIBILITIES["$DATASET"]}" = "yes" ]
then
dump_dataset_$DATASET "$DATE"
+ log_no_lf "|"
fi
done
log
--
To view, visit https://gerrit.wikimedia.org/r/187420
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d695b4fc999ac20d6d1c205482b71a820123055
Gerrit-PatchSet: 1
Gerrit-Project: analytics/refinery
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
