jenkins-bot has submitted this change and it was merged.

Change subject: CSSMin: Optimise isLocalUrl by moving fast comparison forward
......................................................................


CSSMin: Optimise isLocalUrl by moving fast comparison forward

Change-Id: I668e248bd51fb75dfeeef3b74973f517a188c7ba
---
M includes/libs/CSSMin.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/libs/CSSMin.php b/includes/libs/CSSMin.php
index bea6ced..ffe26a9 100644
--- a/includes/libs/CSSMin.php
+++ b/includes/libs/CSSMin.php
@@ -359,7 +359,7 @@
         * @return bool
         */
        public static function isLocalUrl( $maybeUrl ) {
-               if ( !self::isRemoteUrl( $maybeUrl ) && $maybeUrl !== '' && 
$maybeUrl[0] === '/' ) {
+               if ( $maybeUrl !== '' && $maybeUrl[0] === '/' && 
!self::isRemoteUrl( $maybeUrl ) ) {
                        return true;
                }
                return false;

-- 
To view, visit https://gerrit.wikimedia.org/r/186895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I668e248bd51fb75dfeeef3b74973f517a188c7ba
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Bartosz DziewoƄski <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to