jenkins-bot has submitted this change and it was merged.
Change subject: Attempt to improve reliability of cucumber tests
......................................................................
Attempt to improve reliability of cucumber tests
Bug: T87831
Change-Id: I4c1049037f788630c84d4780309d683682fe756f
---
M tests/browser/features/step_definitions/mmv_steps.rb
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/mmv_steps.rb
b/tests/browser/features/step_definitions/mmv_steps.rb
index bdd5817..10bf62e 100644
--- a/tests/browser/features/step_definitions/mmv_steps.rb
+++ b/tests/browser/features/step_definitions/mmv_steps.rb
@@ -2,7 +2,7 @@
Given /^I am at a wiki article with at least two embedded pictures$/ do
visit(E2ETestPage)
- on(E2ETestPage).image1_in_article_element.should be_visible
+ on(E2ETestPage).image1_in_article_element.when_present.should be_visible
end
Given /^I am viewing an image using MMV$/ do
@@ -60,7 +60,7 @@
expect(page.mmv_image_div_element).to be_visible
# Check image content
- expect(page.mmv_image_div_element.image_element.attribute('src')).to match
/Kerala/
+
expect(page.mmv_image_div_element.image_element.when_present.attribute('src')).to
match /Kerala/
# Check basic metadata is present
@@ -93,7 +93,7 @@
expect(page.mmv_image_div_element).to be_visible
# Check image content
- expect(page.mmv_image_div_element.image_element.attribute('src')).to match
'Offsite'
+
expect(page.mmv_image_div_element.image_element.when_present.attribute('src')).to
match 'Offsite'
# Check basic metadata is present
--
To view, visit https://gerrit.wikimedia.org/r/187302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c1049037f788630c84d4780309d683682fe756f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
