Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187635
Change subject: EventEmitter: Remove unneeded Array.prototype.slice call
......................................................................
EventEmitter: Remove unneeded Array.prototype.slice call
apply() requires an Array-like object as second parameter. Arguments
objects fulfill this requirement. We already depend on this elsewhere.
Change-Id: Icd9ca5a1dc4561a33fda13cb1d46f73bbba38681
---
M src/EventEmitter.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/35/187635/1
diff --git a/src/EventEmitter.js b/src/EventEmitter.js
index 7ab463f..c978c9d 100644
--- a/src/EventEmitter.js
+++ b/src/EventEmitter.js
@@ -97,7 +97,7 @@
var eventEmitter = this,
listenerWrapper = function () {
eventEmitter.off( event, listenerWrapper );
- listener.apply( eventEmitter,
Array.prototype.slice.call( arguments, 0 ) );
+ listener.apply( this, arguments );
};
return this.on( event, listenerWrapper );
};
--
To view, visit https://gerrit.wikimedia.org/r/187635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd9ca5a1dc4561a33fda13cb1d46f73bbba38681
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
