jenkins-bot has submitted this change and it was merged.
Change subject: Escape unescaped messages shown in action=info
......................................................................
Escape unescaped messages shown in action=info
Change-Id: Id16d8c8dff73fdacad6c9a4ff7f2919945b7e893
---
M includes/Linker.php
M includes/actions/InfoAction.php
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Linker.php b/includes/Linker.php
index f220eba..3a039f6 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -2043,14 +2043,14 @@
if ( $titleObj->quickUserCan( 'edit' ) ) {
$editLink = self::link(
$titleObj,
- wfMessage( 'editlink' )->text(),
+ wfMessage( 'editlink'
)->escaped(),
array(),
array( 'action' => 'edit' )
);
} else {
$editLink = self::link(
$titleObj,
- wfMessage( 'viewsourcelink'
)->text(),
+ wfMessage( 'viewsourcelink'
)->escaped(),
array(),
array( 'action' => 'edit' )
);
diff --git a/includes/actions/InfoAction.php b/includes/actions/InfoAction.php
index beac822..ff31eb6 100644
--- a/includes/actions/InfoAction.php
+++ b/includes/actions/InfoAction.php
@@ -297,7 +297,7 @@
// Content model of the page
$pageInfo['header-basic'][] = array(
$this->msg( 'pageinfo-content-model' ),
- ContentHandler::getLocalizedName(
$title->getContentModel() )
+ htmlspecialchars( ContentHandler::getLocalizedName(
$title->getContentModel() ) )
);
// Search engine status
@@ -483,7 +483,7 @@
$this->msg( 'pageinfo-firsttime' ),
Linker::linkKnown(
$title,
- $lang->userTimeAndDate(
$firstRev->getTimestamp(), $user ),
+ htmlspecialchars(
$lang->userTimeAndDate( $firstRev->getTimestamp(), $user ) ),
array(),
array( 'oldid' => $firstRev->getId() )
)
@@ -502,7 +502,7 @@
$this->msg( 'pageinfo-lasttime' ),
Linker::linkKnown(
$title,
- $lang->userTimeAndDate(
$this->page->getTimestamp(), $user ),
+ htmlspecialchars(
$lang->userTimeAndDate( $this->page->getTimestamp(), $user ) ),
array(),
array( 'oldid' =>
$this->page->getLatest() )
)
--
To view, visit https://gerrit.wikimedia.org/r/177976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id16d8c8dff73fdacad6c9a4ff7f2919945b7e893
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: MZMcBride <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
