Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187703
Change subject: Use jQuery prop instead of attr for whether box is checked
......................................................................
Use jQuery prop instead of attr for whether box is checked
Bug: T85511
Change-Id: I5c010cb085a1e005e432f5e631d8856512a58a27
---
M modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
M modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageTriage
refs/changes/03/187703/1
diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
index 7620ea3..736ef48 100644
--- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
+++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
@@ -313,7 +313,7 @@
$(
'#mwe-pt-delete-params-form-' + tagKey ).hide();
if ( !_this.selectedTag[tagKey]
) {
- $(
'#mwe-pt-checkbox-delete-' + tagKey ).attr( 'checked', true );
+ $(
'#mwe-pt-checkbox-delete-' + tagKey ).prop( 'checked', true );
// different category
from the selected one, refresh data
if ( _this.selectedCat
!= cat ) {
@@ -337,7 +337,7 @@
}
} else {
// deactivate checkbox
- $(
'#mwe-pt-checkbox-delete-' + tagKey ).attr( 'checked', false );
+ $(
'#mwe-pt-checkbox-delete-' + tagKey ).prop( 'checked', false );
delete
_this.selectedTag[tagKey];
if ( $.isEmptyObject(
_this.selectedTag ) ) {
diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
index 7152c03..b72c9bc 100644
--- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
+++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
@@ -215,7 +215,7 @@
if (
!_this.selectedTag[cat][tagKey] ) {
// activate checkbox
- $(
'#mwe-pt-checkbox-tag-' + tagKey ).attr( 'checked', true );
+ $(
'#mwe-pt-checkbox-tag-' + tagKey ).prop( 'checked', true );
_this.selectedTagCount++;
_this.selectedTag[cat][tagKey] = tagSet[tagKey];
if ( destCat ) {
@@ -235,7 +235,7 @@
}
} else {
// deactivate checkbox
- $(
'#mwe-pt-checkbox-tag-' + tagKey ).attr( 'checked', false );
+ $(
'#mwe-pt-checkbox-tag-' + tagKey ).prop( 'checked', false );
_this.selectedTagCount--;
delete
_this.selectedTag[cat][tagKey];
if ( destCat ) {
@@ -400,7 +400,7 @@
delete
_this.selectedTag[cat][key];
_this.selectedTagCount--;
_this.refreshTagCountDisplay( key, destCat ? destCat : cat );
- $(
'#mwe-pt-checkbox-tag-' + key ).attr( 'checked', false );
+ $(
'#mwe-pt-checkbox-tag-' + key ).prop( 'checked', false );
_this.hideParamsLink(
key );
break;
}
--
To view, visit https://gerrit.wikimedia.org/r/187703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c010cb085a1e005e432f5e631d8856512a58a27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
