jenkins-bot has submitted this change and it was merged.
Change subject: Fix multiple major IE 8 issues
......................................................................
Fix multiple major IE 8 issues
* Remove all uses of :empty and :not (except where it's intentionally
used to target IE 8). Moved the parentheses for pipelist into
templates.
* Drop <time> and just use a <span> with a class instead.
IE 8 was treating <time> as a self-closing tag.
To fix that, we'd either have to call createElement on the HTML5
elements *before* the IE 8 parser hits them (which means some kind of
top script), or just not use the element. The latter is simpler.
* Fix scroll detection (both when to affix and updating the title)
by using $( window ).scrollTop() and dropping
margin-top. The latter was being used, but the actual margin top
is 0. The problem is that IE 8 returns the computed value as
"auto", which can not be parsed. Since it's 0 anyway, we can drop
it.
* Provide alternative to vh unit (vh is not supported before IE 9)
* Fix trailing comma in object literal (not allowed in IE 8 or
ECMAScript 3).
* Replace {{~null~}} with {{~noop~}} to work around old IE's strictness
about reserved words. With null, there will be generated code with e.g.
depth0.null, which IE 8 is not able to parse.
I have pushed a fix for this upstream as
https://github.com/wycats/handlebars.js/pull/940
but this works around it as well.
* Stop IE from prompting you whether you want to leave the page
when you click on javascript:void(0) links.
* Fix big gap caused by a style that IE 8 didn't see because it was
in a media query.
* Minor reformatting (mainly for whitespace) in pipelist templates
Bug: T74059
Bug: T75819
Bug: T86411
Bug: T75817
Bug: T87120
Bug: T87121
Change-Id: I861696290dde4db0c755fce7627a141f9dc7c161
---
M handlebars/compiled/flow_block_board-history.handlebars.php
M handlebars/compiled/flow_block_topic.handlebars.php
M handlebars/compiled/flow_block_topic_history.handlebars.php
M handlebars/compiled/flow_block_topic_moderate_post.handlebars.php
M handlebars/compiled/flow_block_topic_moderate_topic.handlebars.php
M handlebars/compiled/flow_block_topiclist.handlebars.php
M handlebars/compiled/flow_post.handlebars.php
M handlebars/compiled/timestamp.handlebars.php
M handlebars/flow_block_board-history.handlebars
M handlebars/flow_block_topic_history.handlebars
M handlebars/flow_moderation_actions_list.handlebars
M handlebars/flow_post_author.handlebars
M handlebars/flow_topic_titlebar_watch.handlebars
M handlebars/timestamp.handlebars
M modules/engine/components/board/base/flow-board-api-events.js
M modules/engine/components/board/base/flow-board-load-events.js
M modules/engine/components/board/features/flow-board-loadmore.js
M modules/engine/components/board/features/flow-board-navigation.js
M modules/engine/components/board/features/flow-board-toc.js
M modules/engine/misc/flow-handlebars.js
M modules/styles/board/navigation.less
M modules/styles/board/timestamps.less
M modules/styles/common.less
23 files changed, 217 insertions(+), 189 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
--
To view, visit https://gerrit.wikimedia.org/r/185392
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I861696290dde4db0c755fce7627a141f9dc7c161
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
